public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Tom Lane <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: ecpg_config.h symbol missing with meson
Date: Wed, 24 Apr 2024 08:32:26 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On 17.04.24 18:15, Tom Lane wrote:
> Peter Eisentraut <[email protected]> writes:
>> I checked the generated ecpg_config.h with make and meson, and the meson
>> one is missing
> 
>> #define HAVE_LONG_LONG_INT 1
> 
>> This is obviously quite uninteresting, since that is required by C99.
>> But it would be more satisfactory if we didn't have discrepancies like
>> that.  Note that we also kept ENABLE_THREAD_SAFETY in ecpg_config.h for
>> compatibility.
>> ...
>> Alternatively, we could remove the symbol from the make side.
> 
> Think I'd vote for removing it, since we use it nowhere.
> The ENABLE_THREAD_SAFETY precedent feels a little bit different,
> since there's not the C99-requires-the-feature angle.

Ok, fixed by removing instead.

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: ecpg_config.h symbol missing with meson
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox