pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Zhang Mingli <zmlpostgres@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Reducing duplicativeness of EquivalenceClass-derived clauses
Date: Thu, 27 Oct 2022 09:29:02 -0400
Message-ID: <644164.1666877342@sss.pgh.pa.us> (raw)
In-Reply-To: <2faecd55-6786-471c-84ac-36aa7149abee@Spark>
References: <78062.1666735746@sss.pgh.pa.us>
	<2faecd55-6786-471c-84ac-36aa7149abee@Spark>

Zhang Mingli <zmlpostgres@gmail.com> writes:
> How about combine ec->ec_sources and ec->derives as one list for less codes?

Keeping them separate is required for the broken-EC code paths.
Even if it weren't, I wouldn't merge them just to save a couple
of lines of code --- I think it's useful to be able to tell which
clauses the EC started from.

			regards, tom lane





view thread (6+ messages)  latest in thread

Message-ID: <644164.1666877342@sss.pgh.pa.us>
Permalink:  ../644164.1666877342@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/644164.1666877342@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, zmlpostgres@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Reducing duplicativeness of EquivalenceClass-derived clauses
  In-Reply-To: <644164.1666877342@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox