From: Anton A. Melnikov <a.melnikov@postgrespro.ru>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?
Date: Wed, 24 Apr 2024 12:32:46 +0300
Message-ID: <6457915f-f880-452d-a4ae-21a5bfbccbd3@postgrespro.ru> (raw)
In-Reply-To: <FC257A2E-D989-46DC-8232-AB14C3D7A0B2@yesql.se>
References: <0841ec77-47e5-452a-adb4-c6fa55d605fc@postgrespro.ru>
<474746ef-fa9f-400e-902e-3bb018320ca0@eisentraut.org>
<44faf5a1-1e84-4ae5-9ea7-106af77cf96b@postgrespro.ru>
<FC257A2E-D989-46DC-8232-AB14C3D7A0B2@yesql.se>
On 24.04.2024 12:19, Daniel Gustafsson wrote:
>> On 24 Apr 2024, at 11:13, Anton A. Melnikov <a.melnikov@postgrespro.ru> wrote:
>>
>> On 24.04.2024 12:02, Peter Eisentraut wrote:
>>> On 19.04.24 05:50, Anton A. Melnikov wrote:
>>>>
>>>> May be better use this macro everywhere in C code?
>>> I don't know. I don't find XLOG_CONTROL_FILE to be a very intuitive proxy for "pg_control".
>
> Maybe, but inconsistent usage is also unintuitive.
>
>> Then maybe replace XLOG_CONTROL_FILE with PG_CONTROL_FILE?
>>
>> The PG_CONTROL_FILE_SIZE macro is already in the code.
>> With the best regards,
>
> XLOG_CONTROL_FILE is close to two decades old so there might be extensions
> using it (though the risk might be slim), perhaps using offering it as as well
> as backwards-compatability is warranted should we introduce a new name?
>
To ensure backward compatibility we can save the old macro like this:
#define XLOG_CONTROL_FILE "global/pg_control"
#define PG_CONTROL_FILE XLOG_CONTROL_FILE
With the best wishes,
--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.melnikov@postgrespro.ru, daniel@yesql.se, michael@paquier.xyz, peter@eisentraut.org
Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?
In-Reply-To: <6457915f-f880-452d-a4ae-21a5bfbccbd3@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox