From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: coelho@cri.ensmp.fr
Cc: rafia.sabih@enterprisedb.com
Cc: michael.paquier@gmail.com
Cc: Langote_Amit_f8@lab.ntt.co.jp
Cc: robertmhaas@gmail.com
Cc: pavel.stehule@gmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: pgbench - allow to store select results into variables
Date: Mon, 04 Sep 2017 13:46:52 -0400
Message-ID: <6611.1504547212@sss.pgh.pa.us> (raw)
In-Reply-To: <20170420.170640.2147960429835861950.t-ishii@sraoss.co.jp>
References: <alpine.DEB.2.20.1704171524050.4025@lancre>
<20170417.181123.1539611157606514675.t-ishii@sraoss.co.jp>
<alpine.DEB.2.20.1704171959080.1741@lancre>
<20170420.170640.2147960429835861950.t-ishii@sraoss.co.jp>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Tatsuo Ishii <ishii@sraoss.co.jp> writes:
>> Here is a v3 with a more precise comment.
> Looks good to me. I have marked the patch status as "Ready for
> committer".
LGTM too. Pushed with a minor adjustment to make parseVariable()
have exactly the same test as valid_variable_name().
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, ishii@sraoss.co.jp, coelho@cri.ensmp.fr, rafia.sabih@enterprisedb.com, michael.paquier@gmail.com, Langote_Amit_f8@lab.ntt.co.jp, robertmhaas@gmail.com, pavel.stehule@gmail.com
Subject: Re: pgbench - allow to store select results into variables
In-Reply-To: <6611.1504547212@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox