From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove win32ver.rc from version_stamp.pl
Date: Tue, 10 Mar 2020 11:54:58 +0100
Message-ID: <67111310-fbdb-132d-05b1-9566a6b59e98@2ndquadrant.com> (raw)
In-Reply-To: <10432.1583765753@sss.pgh.pa.us>
References: <1ee46ac4-a9b2-4531-bf54-5ec2e374634d@2ndquadrant.com>
<10989.1583103086@sss.pgh.pa.us>
<5599e5cb-7d07-c4fc-24f9-273c4b7a2eec@2ndquadrant.com>
<10432.1583765753@sss.pgh.pa.us>
On 2020-03-09 15:55, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> On 2020-03-01 23:51, Tom Lane wrote:
>>> In general, while I'm on board with the idea, I wonder whether it
>>> wouldn't be smarter to keep on defining PG_MAJORVERSION as a string,
>>> and just add PG_MAJORVERSION_NUM alongside of it.
>
>> Agreed. Here is another patch.
>
> This version LGTM. (I can't actually test the Windows aspects
> of this, but I assume you did.)
committed
> I'm wondering a little bit whether it'd be worth back-patching the
> additions of the new #defines. That would cut about five years off
> the time till they could be relied on by extensions. However,
> I'm not sure anyone is eager to rely on them, so it may not be
> worth the effort.
I doubt external code really needs these symbols. You can always use
PG_VERSION_NUM.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us
Subject: Re: Remove win32ver.rc from version_stamp.pl
In-Reply-To: <67111310-fbdb-132d-05b1-9566a6b59e98@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox