pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Artur Zakirov <a.zakirov@postgrespro.ru>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: sulamul@gmail.com, Pavel Stehule <pavel.stehule@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Alex Ignatov <a.ignatov@postgrespro.ru>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: sul_amul@yahoo.co.in, pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Bug in to_timestamp().
Date: Fri, 06 Jul 2018 17:30:55 -0400
Message-ID: <69860.1530912655@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPpHfdsjXhqbPd8L42YMrd+KLdXKzMpVdyaMvDZE46sGqRF2xg@mail.gmail.com>
References: <20180206091648.GA8507@zakirov.localdomain>
	<CA+q6zcVOmcmbDZnrJdxighp=95xdkGYOucabtay+CpWU8UDqkA@mail.gmail.com>
	<CA+q6zcX6Svkn1Cf0GDvSqCEV-SFC6ET2bxjXQpWaoZYWAordUA@mail.gmail.com>
	<20180212114943.GA6629@zakirov.localdomain>
	<CA+q6zcUS3fQGLoeLcuJLtz-gRD6vHqpn1fBe0cnORdx93QtO4w@mail.gmail.com>
	<20180217090239.GA14632@arthur.localdomain>
	<CA+q6zcXLYS4yKRa1n79ORqPUfLJb0mVyJXRfHDcbGZ44o8hCCw@mail.gmail.com>
	<CA+q6zcXjG34kQy_hskZQjhajFCR8XhfHsHXL2orB4te2Vwdmbg@mail.gmail.com>
	<20180302093328.GA18933@zakirov.localdomain>
	<CA+q6zcWfntt2MPZYmzK71UmoWS3DFgYbYhTWU7Fgg1y9CMaOcw@mail.gmail.com>
	<20180302125132.GA25129@zakirov.localdomain>
	<CAPpHfdsjXhqbPd8L42YMrd+KLdXKzMpVdyaMvDZE46sGqRF2xg@mail.gmail.com>

Alexander Korotkov <a.korotkov@postgrespro.ru> writes:
> I tool a look at this patch.  It looks good for me.  It applies
> cleanly on last master, builds without warnings, passes tests.
> Functionality seems to be well-covered by documentation and regression
> tests.  So, I'm going to commit it if no objections.

AFAIR, the argument was mainly over whether we agreed with the proposed
behavioral changes.  It seems a bit premature to me to commit given that
there's not consensus on that.

			regards, tom lane




view thread (138+ messages)  latest in thread

Message-ID: <69860.1530912655@sss.pgh.pa.us>
Permalink:  ../69860.1530912655@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/69860.1530912655@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, a.korotkov@postgrespro.ru, a.zakirov@postgrespro.ru, 9erthalion6@gmail.com, robertmhaas@gmail.com, thomas.munro@enterprisedb.com, pavel.stehule@gmail.com, david.g.johnston@gmail.com, a.ignatov@postgrespro.ru, bruce@momjian.us
  Subject: Re: [HACKERS] Bug in to_timestamp().
  In-Reply-To: <69860.1530912655@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox