From: Euler Taveira <euler@eulerto.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: split tablecmds.c
Date: Mon, 01 Dec 2025 16:13:22 -0300
Message-ID: <6a119f95-2309-464f-89d1-e17ff42a1a67@app.fastmail.com> (raw)
In-Reply-To: <202512011754.hpa4uqkqtq4f@alvherre.pgsql>
References: <202512011754.hpa4uqkqtq4f@alvherre.pgsql>
On Mon, Dec 1, 2025, at 3:18 PM, Álvaro Herrera wrote:
> My first thought would be to move code that deals with catalog changes
> to files in catalog/. Also a couple of functions related to tablespaces
> could be perhaps be moved to commands/tablespace.c.
>
As Tom said partitioning has a big chunk of lines of code. I bet that's the
biggest portion. It seems a good candidate to be moved to a new file
(partitioning and inheritance). Besides your suggestion, I would add things
that set properties (RLS, reloptions, AM, replica identity, generated columns)
to another file (tableutils.c?).
--
Euler Taveira
EDB https://www.enterprisedb.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: euler@eulerto.com, alvherre@kurilemu.de, nathandbossart@gmail.com
Subject: Re: split tablecmds.c
In-Reply-To: <6a119f95-2309-464f-89d1-e17ff42a1a67@app.fastmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox