pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: jesper.pedersen@redhat.com, Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Oskari Saarenmaa <os@ohmu.fi>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Tobias Oberstein <tobias.oberstein@gmail.com>
Subject: Re: pread() and pwrite()
Date: Wed, 7 Nov 2018 10:03:39 -0500
Message-ID: <6b69fc80-03c2-b445-907d-89cdbde7f1fa@2ndQuadrant.com> (raw)
In-Reply-To: <26123.1541601037@sss.pgh.pa.us>
References: <20181105155918.jg36uj4rtnxwqtzt@alvherre.pgsql>
	<1791.1541438632@sss.pgh.pa.us>
	<CAEepm=1GmuQ---ZDmmDzU6uS0QF==PeD1N-XLY7pSfndxTpnfQ@mail.gmail.com>
	<856530e2-260d-1d61-ec18-595778868a1b@redhat.com>
	<CAEepm=0+GizsKRRd=7wrL0n8VMKadR0=o99VWiXD58oJyJOUCQ@mail.gmail.com>
	<cb062f4d-55b8-28be-b55f-2e593a3b3755@redhat.com>
	<4ab64856-6822-ec37-934f-baab06413233@2ndQuadrant.com>
	<26123.1541601037@sss.pgh.pa.us>


On 11/7/18 9:30 AM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 11/7/18 7:26 AM, Jesper Pedersen wrote:
>>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2018-11-07%2001%3A01%3A01
>> And lousyjack, which uses a slightly different way of calling valgrind,
>> and thus got past initdb, found a bunch more:
>> <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-11-07%2001%3A33%3A01;
> I'm confused by this.  Surely the pwrite-based code is writing exactly the
> same data as before.  Do we have to conclude that valgrind is complaining
> about passing uninitialized data to pwrite() when it did not complain
> about exactly the same thing for write()?
>
> [ looks ... ]  No, what we have to conclude is that the write-related
> suppressions in src/tools/valgrind.supp need to be replaced or augmented
> with pwrite-related ones.


Yeah. I just trawled through the lousyjack logs and it looks like all 
the cases it reported could be handled by:

{
     padding_XLogRecData_pwrite
     Memcheck:Param
     pwrite64(buf)

     ...
     fun:XLogWrite
}

cheers


andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (41+ messages)  latest in thread

Message-ID: <6b69fc80-03c2-b445-907d-89cdbde7f1fa@2ndQuadrant.com>
Permalink:  ../6b69fc80-03c2-b445-907d-89cdbde7f1fa@2ndQuadrant.com/
Also on:    postgresql.org/message-id/6b69fc80-03c2-b445-907d-89cdbde7f1fa@2ndQuadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andrew.dunstan@2ndquadrant.com, tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com, alvherre@2ndquadrant.com, magnus@hagander.net, os@ohmu.fi, tobias.oberstein@gmail.com
  Subject: Re: pread() and pwrite()
  In-Reply-To: <6b69fc80-03c2-b445-907d-89cdbde7f1fa@2ndQuadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox