public inbox for [email protected]  

help / color / mirror / Atom feed

From: [email protected]
To: Amul Sul <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: tweak to a few index tests to hits ambuildempty() routine.
Date: Wed, 21 Sep 2022 14:10:42 +0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAJ_b97etWoGCxOGrtZSZ4sZAh-7NjZvLQbmnqi0ka3Lg2=mQA@mail.gmail.com>
References: <CAAJ_b95nneRCLM-=qELEdgCYSk6W_++-C+Q_t+wH3SW-hF50iw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAAJ_b97etWoGCxOGrtZSZ4sZAh-7NjZvLQbmnqi0ka3Lg2=mQA@mail.gmail.com>

After analyzing this, I found out why we don't reach that Assert but we 
have coverage shown - firstly, it reached via another test, vacuum; 
secondly, it depends on the gcc optimization flag. We reach that Assert 
only when using -O0.
If we build with -O2 or -Og that function is not reached (due to 
different results of the heap_prune_satisfies_vacuum() check inside 
heap_page_prune()).
But as  the make checks mostly (including the buildfarm testing) 
performed  with -O2/-Og, it looks like that after 4fb5c794e5 we have 
lost the coverage provided by the 4c51a2d1e4.

Amul Sul писал 2022-09-14 14:28:
> On Wed, Sep 14, 2022 at 12:16 PM <[email protected]> wrote:
>> 
>> I still wonder, if assert doesn't catch why that place is marked as
>> covered here?
>> https://coverage.postgresql.org/src/backend/access/gin/ginvacuum.c.gcov.html
>> 
> 
> Probably other tests cover that.
> 
> Regards,
> Amul

view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: tweak to a few index tests to hits ambuildempty() routine.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox