pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Marina Polyakova <m.polyakova@postgrespro.ru>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com
Cc: rjuju123@gmail.com
Cc: daniel@manitou-mail.org
Cc: AndrewBille@gmail.com
Cc: michael@paquier.xyz
Subject: Re: ICU for global collation
Date: Sat, 1 Oct 2022 14:07:29 +0200
Message-ID: <73f18f58-5eaa-b09b-407d-a862a48635b1@enterprisedb.com> (raw)
In-Reply-To: <e94aca035bf0b92fac42d204ad385552@postgrespro.ru>
References: <1f86f120-7b02-68f6-a434-132d054afe33@enterprisedb.com>
	<38d2aac40a991b20adf032e509c6eff5@postgrespro.ru>
	<6dd6db0984d86a51b7255ba79f111971@postgrespro.ru>
	<20220915.155210.529619933474389138.horikyota.ntt@gmail.com>
	<a739cd973cd3c911d9bf582b6febba1c@postgrespro.ru>
	<65ef1a8a-1fc3-3dc3-c7aa-6b9f649014b2@enterprisedb.com>
	<9ba4cd1ea6ed6b7b15c0ff15e6f540cd@postgrespro.ru>
	<218b963e-dd66-626a-abd8-962afb587876@enterprisedb.com>
	<36737f855bf3c44e701097cafd0ee2c9@postgrespro.ru>
	<f38dadbe-fb37-68a5-fe7b-2706ce2580c3@enterprisedb.com>
	<e94aca035bf0b92fac42d204ad385552@postgrespro.ru>

On 22.09.22 20:06, Marina Polyakova wrote:
> On 2022-09-21 17:53, Peter Eisentraut wrote:
>> Committed with that test, thanks.  I think that covers all the ICU
>> issues you reported for PG15 for now?
> 
> I thought about the order of the ICU checks - if it is ok to check that 
> the selected encoding is supported by ICU after printing all the locale 
> & encoding information, why not to move almost all the ICU checks here?..

It's possible that we can do better, but I'm not going to add things 
like that to PG 15 at this point unless it fixes a faulty behavior.






view thread (111+ messages)  latest in thread

Message-ID: <73f18f58-5eaa-b09b-407d-a862a48635b1@enterprisedb.com>
Permalink:  ../73f18f58-5eaa-b09b-407d-a862a48635b1@enterprisedb.com/
Also on:    postgresql.org/message-id/73f18f58-5eaa-b09b-407d-a862a48635b1@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, m.polyakova@postgrespro.ru, horikyota.ntt@gmail.com, pryzby@telsasoft.com, rjuju123@gmail.com, daniel@manitou-mail.org, AndrewBille@gmail.com, michael@paquier.xyz
  Subject: Re: ICU for global collation
  In-Reply-To: <73f18f58-5eaa-b09b-407d-a862a48635b1@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox