pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
To: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: tgl@sss.pgh.pa.us
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: WIP: new system catalog pg_wait_event
Date: Fri, 18 Aug 2023 10:57:28 +0200
Message-ID: <7422edbb-bf81-4f4f-b260-ce4d39a31007@gmail.com> (raw)
In-Reply-To: <ZN6hQDvWkLVaps9o@paquier.xyz>
References: <c915434a-3d3a-4135-8f3a-fca0cf22c6ae@gmail.com>
	<ZNNGq7DTv9ur5113@paquier.xyz>
	<b71d1977-1a8b-4129-8c03-533031dbd004@gmail.com>
	<ZNmvegQirGI9ifVw@paquier.xyz>
	<2f84b397-d020-493c-924c-610b9dd18f8d@gmail.com>
	<ZNxrMdmgrlovw1qD@paquier.xyz>
	<f2204399-cfdb-40e7-9479-9373ec6ba0ab@gmail.com>
	<735fbd560ae914c96faaa23cc8d9a118@oss.nttdata.com>
	<d28ad85d-1deb-4648-92a0-f38273fc91ca@gmail.com>
	<393fe340ab6980f399402a7dfbe13c4c@oss.nttdata.com>
	<ZN6hQDvWkLVaps9o@paquier.xyz>

Hi,

On 8/18/23 12:37 AM, Michael Paquier wrote:
> On Thu, Aug 17, 2023 at 04:37:22PM +0900, Masahiro Ikeda wrote:
>> On 2023-08-17 14:53, Drouvot, Bertrand wrote:
>> BTW, is it better to start with "Waiting" like any other lines?
>> For example, "Waiting for custom event \"worker_spi_main\" defined by an
>> extension".
> 
> Using "Waiting for custom event" is a good term here. 

Yeah, done in v8 just shared up-thread.

> I am wondering
> if this should be s/extension/module/, as an event could be set by a
> loaded library, which may not be set with CREATE EXTENSION.
> 

I think that removing "extension" sounds weird given the fact that the
wait event type is "Extension" (that could lead to confusion).

I did use "defined by an extension module" in v8 (also that's aligned with
the wording used in wait_event.h).

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com





view thread (34+ messages)  latest in thread

Message-ID: <7422edbb-bf81-4f4f-b260-ce4d39a31007@gmail.com>
Permalink:  ../7422edbb-bf81-4f4f-b260-ce4d39a31007@gmail.com/
Also on:    postgresql.org/message-id/7422edbb-bf81-4f4f-b260-ce4d39a31007@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: bertranddrouvot.pg@gmail.com, michael@paquier.xyz, ikedamsh@oss.nttdata.com, horikyota.ntt@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: WIP: new system catalog pg_wait_event
  In-Reply-To: <7422edbb-bf81-4f4f-b260-ce4d39a31007@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox