From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: tableam.h fails cpluspluscheck
Date: Fri, 31 May 2019 09:57:31 -0400
Message-ID: <74837.1559311051@sss.pgh.pa.us> (raw)
In-Reply-To: <20190530204705.3xnmpuxd23tovbyb@alap3.anarazel.de>
References: <53941.1559239260@sss.pgh.pa.us>
<20190530204705.3xnmpuxd23tovbyb@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2019-05-30 14:01:00 -0400, Tom Lane wrote:
>> Kinda looks like you can't get away with using "struct" on a forward
>> declaration of something that is not actually a struct type.
> Ugh. Odd that only C++ compilers complain. I just removed the typedef,
> it's not needed anymore (it used to be neccessary before moving
> IndexBuildCallback's definition to tableam.h - but was wrong then too,
> just cpluspluscheck didn't notice).
Cool, thanks.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: tableam.h fails cpluspluscheck
In-Reply-To: <74837.1559311051@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox