agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Antonin Houska <ah@cybertec.at>
To: alvherre@kurilemu.de
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Robert Treat <rob@xzilla.net>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Fujii Masao <masao.fujii@gmail.com>
Subject: Re: Adding REPACK [concurrently]
Date: Thu, 09 Oct 2025 08:38:15 +0200
Message-ID: <7535.1759991895@localhost> (raw)
In-Reply-To: <202510070909.biaseppvydvg@alvherre.pgsql>
References: <202510070909.biaseppvydvg@alvherre.pgsql>
Álvaro Herrera <alvherre@kurilemu.de> wrote:
> On 2025-Sep-26, Mihail Nikalayeu wrote:
>
> > Should we rename it to repack_context to be aligned with the calling side?
>
> Sure, done.
>
> > > cmd == REPACK_COMMAND_CLUSTER ? "CLUSTER" : "REPACK",
> >
> > May be changed to RepackCommandAsString
>
> Oh, of course.
>
> > Documentation of pg_repackdb contains a lot of "analyze" and even
> > "--analyze" parameter - but I can't see anything related in the code.
>
> Hmm, yeah, that was missing. I added it. In doing so I noticed that
> because vacuumdb allows a column list to be given, then we should do
> likewise here, both in pg_repackdb and in the REPACK command, so I added
> support for that.
+ /*
+ * Make sure ANALYZE is specified if a column list is present.
+ */
+ if ((params->options & CLUOPT_ANALYZE) == 0 && stmt->relation->va_cols != NIL)
+ ereport(ERROR,
+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+ errmsg("ANALYZE option must be specified when a column list is provided")));
Shouldn't the user documentation mention this restriction?
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
view thread (416+ messages) latest in thread
Message-ID: <7535.1759991895@localhost>
Permalink: ../7535.1759991895@localhost/
Also on: postgresql.org/message-id/7535.1759991895@localhost
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, alvherre@kurilemu.de, mihailnikalayeu@gmail.com, rob@xzilla.net, pgsql-hackers@lists.postgresql.org, masao.fujii@gmail.com
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <7535.1759991895@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox