agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: torikoshia <torikoshia@oss.nttdata.com>
To: Alexander Kukushkin <cyberdemn@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: michael@paquier.xyz
Cc: pgsql-hackers@postgresql.org
Cc: bungina@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_rewind WAL segments deletion pitfall
Date: Wed, 18 Oct 2023 15:50:39 +0900
Message-ID: <763cac924055f1669578bea950c667c7@oss.nttdata.com> (raw)
In-Reply-To: <CAFh8B=kqWWmMKT6T6Hea2d1PvBHsSOXBformB7Dr09GWEOOkLw@mail.gmail.com>
References: <8b385bb6d5f87e54c1c6333fece0444a@oss.nttdata.com>
<ZORIVnxs+lXoEAQG@paquier.xyz>
<CAFh8B=k2DUwruBA3djsMf3b_wfqeN092iqaDcZYJ4PAgnne2KA@mail.gmail.com>
<20230824.094538.2107929879048686192.horikyota.ntt@gmail.com>
<bb706f8393c5207812268a5a2e3f98d7@oss.nttdata.com>
<CAFh8B=m0TuTNyPzOC6zWrVH2iOEnuNyuPSazqTgjVbd=nt3B2Q@mail.gmail.com>
<CAFh8B=kqWWmMKT6T6Hea2d1PvBHsSOXBformB7Dr09GWEOOkLw@mail.gmail.com>
Thanks for the patch.
I tested the v6 patch using the test script attached on [1], old primary
has succeeded to become new standby.
I have very minor questions on the regression tests mainly regarding the
consistency with other tests for pg_rewind:
> +setup_cluster;
> +create_standby;
Would it be better to add parentheses?
Also should we add "RewindTest::" for these function?
> +primary_psql("create table t(a int)");
> +primary_psql("insert into t values(0)");
> +primary_psql("select pg_switch_wal()");
..
Should 'select', 'create', etc be capitalized?
> my $false = "$^X -e 'exit(1)'";
I feel it's hard to understand what does this mean.
Isn't it better to add comments and describe this is for windows
environments?
--
Regards,
--
Atsushi Torikoshi
NTT DATA Group Corporation
view thread (50+ messages) latest in thread
Message-ID: <763cac924055f1669578bea950c667c7@oss.nttdata.com>
Permalink: ../763cac924055f1669578bea950c667c7@oss.nttdata.com/
Also on: postgresql.org/message-id/763cac924055f1669578bea950c667c7@oss.nttdata.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: torikoshia@oss.nttdata.com, cyberdemn@gmail.com, horikyota.ntt@gmail.com, michael@paquier.xyz, bungina@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_rewind WAL segments deletion pitfall
In-Reply-To: <763cac924055f1669578bea950c667c7@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox