pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: torikoshia <torikoshia@oss.nttdata.com>
Cc: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add reject_limit option to file_fdw
Date: Wed, 27 Nov 2024 23:45:23 +0900
Message-ID: <766300e6-b95b-4e82-b815-c55c6d16dc77@oss.nttdata.com> (raw)
In-Reply-To: <ed549b14a025b7f4b7451c035205d762@oss.nttdata.com>
References: <bab68a9fc502b12693f0755b6f35f327@oss.nttdata.com>
	<fd14c3a0-a036-4bce-b5f8-4af83259eae1@oss.nttdata.com>
	<54747389a562688eab7077b144daff6a@oss.nttdata.com>
	<2b3ad6d4-e05f-4188-8cfe-1fd9d949a9c9@oss.nttdata.com>
	<192ede1e4c2b34b853e5ac46f8dee50b@oss.nttdata.com>
	<d7a03664-bef5-49b0-998f-3ea5356b53c9@oss.nttdata.com>
	<f02ec7b6c348b9fbeeb69657733da9ba@oss.nttdata.com>
	<20241112145114.ba288defc684699bf8646942@sraoss.co.jp>
	<2f03bf95556c4c41d6b1659e74b346c7@oss.nttdata.com>
	<20241113231706.09e5b5ea9640289312835be8@sraoss.co.jp>
	<a7d70e35229e2075b371cd1e81222244@oss.nttdata.com>
	<336dd0aa-f91b-4953-b0a0-b87215c571d2@oss.nttdata.com>
	<ed549b14a025b7f4b7451c035205d762@oss.nttdata.com>



On 2024/11/21 15:43, torikoshia wrote:
> Thanks for the update! Agreed.
> I think the validator tests related to the on_error option you added are sufficient.

I've pushed the patch. Thanks!

> As for the other file_fdw options, I'm a bit concerned whether it would be better to add validator tests for cases like when 'encoding' is 'unsupported', but that should be discussed in another thread.

I'm not sure how valuable it is to add that test, but yes,
it would be better to start a new thread for discussion if needed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION






view thread (16+ messages)

Message-ID: <766300e6-b95b-4e82-b815-c55c6d16dc77@oss.nttdata.com>
Permalink:  ../766300e6-b95b-4e82-b815-c55c6d16dc77@oss.nttdata.com/
Also on:    postgresql.org/message-id/766300e6-b95b-4e82-b815-c55c6d16dc77@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, torikoshia@oss.nttdata.com, nagata@sraoss.co.jp
  Subject: Re: Add reject_limit option to file_fdw
  In-Reply-To: <766300e6-b95b-4e82-b815-c55c6d16dc77@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox