From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.
Date: Wed, 19 May 2021 13:51:28 +0900
Message-ID: <7713989e-add9-b2ca-8804-236fc924f283@oss.nttdata.com> (raw)
In-Reply-To: <20210519.095308.1406400973910988323.horikyota.ntt@gmail.com>
References: <f706876c-4894-0ba5-6f4d-79803eeea21b@oss.nttdata.com>
<20210518.095805.1634592437754592061.horikyota.ntt@gmail.com>
<ce4ce624-be5c-c9fa-919c-e0a646c5d03c@oss.nttdata.com>
<20210519.095308.1406400973910988323.horikyota.ntt@gmail.com>
On 2021/05/19 9:53, Kyotaro Horiguchi wrote:
> At Tue, 18 May 2021 12:48:38 +0900, Fujii Masao <masao.fujii@oss.nttdata.com> wrote in
>> Currently a promotion causes all available WAL to be replayed before
>> a standby becomes a primary whether it was in paused state or not.
>> OTOH, something like immediate promotion (i.e., standby becomes
>> a primary without replaying outstanding WAL) might be useful for
>> some cases. I don't object to that.
>
> Mmm. I was confused with recovery target + pause. Actually promotion
> works as so and it is documented. Anyway it is a matter of the next
> version.
>
> I forgot to mention the patch itself, but what the patch does looks
> fine to me. Disabling pause after setting SharedProteIsTriggered
> prevents later re-pausing (from the sql function).
Thanks for the review! I pushed the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, horikyota.ntt@gmail.com
Subject: Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.
In-Reply-To: <7713989e-add9-b2ca-8804-236fc924f283@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox