pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: SLRU statistics
Date: Wed, 13 May 2020 12:55:50 -0400
Message-ID: <7838.1589388950@sss.pgh.pa.us> (raw)
In-Reply-To: <ffc93765-84f2-6363-fb3e-4d694c996f37@oss.nttdata.com>
References: <20200513161406.GA437@alvherre.pgsql>
	<ffc93765-84f2-6363-fb3e-4d694c996f37@oss.nttdata.com>

Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> But since the counter that postmaster incremented is propagated to
> child processes via fork, it should be zeroed at postmaster or the
> beginning of child process? Otherwise that counter always starts
> with non-zero in child process.

Yes, if the postmaster is incrementing these counts then we would
have to reset them at the start of each child process.  I share
Alvaro's feeling that that's bad and we don't want to do it.

>> (IIRC only the Async module is doing that.)

Hm, maybe we can fix that.

			regards, tom lane





view thread (49+ messages)  latest in thread

Message-ID: <7838.1589388950@sss.pgh.pa.us>
Permalink:  ../7838.1589388950@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/7838.1589388950@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, masao.fujii@oss.nttdata.com, alvherre@2ndquadrant.com, tomas.vondra@2ndquadrant.com, masahiko.sawada@2ndquadrant.com, tsunakawa.takay@fujitsu.com
  Subject: Re: SLRU statistics
  In-Reply-To: <7838.1589388950@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox