pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: SLRU statistics
Date: Thu, 14 May 2020 15:45:26 -0400
Message-ID: <13487.1589485526@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoZGszNmRrdR_i3emu7MhiEbH3hos0cq4U4fTs-Z+6PUzw@mail.gmail.com>
References: <20200229205518.xrxo535zgd7cl6no@development>
	<20200327004111.md4suoi6u5suv2qe@development>
	<20200328002630.2nz5y3dvymqnvxtv@development>
	<20200402004136.wodwftan45mcwggm@development>
	<f02fd0ec-a240-b5bf-9992-5faf582738f1@oss.nttdata.com>
	<20200430181901.24tlriahmafi4sfn@development>
	<0e1c8904-13be-ab70-0096-54f0b30e43ba@oss.nttdata.com>
	<20200502000818.nn4kpewiput42bnb@development>
	<49b8ad17-f6d9-a086-a952-ff1fec3ac1b3@oss.nttdata.com>
	<20200502105500.hwhba3d6s3hlrqf6@development>
	<20200502165905.brfxv6dk5vjdbgti@development>
	<976bbb73-a112-de3c-c488-b34b64609793@oss.nttdata.com>
	<fd082235-c8dc-3d99-3703-1ba183dc252e@oss.nttdata.com>
	<CA+TgmoZGszNmRrdR_i3emu7MhiEbH3hos0cq4U4fTs-Z+6PUzw@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> I'm confused by why SLRU statistics are reported by messages sent to
> the stats collector rather than by just directly updating shared
> memory.

It would be better to consider that as an aspect of the WIP stats
collector redesign, rather than inventing a bespoke mechanism for
SLRU stats that's outside the stats collector (and, no doubt,
would have its own set of bugs).  We don't need to invent even more
pathways for this sort of data.

			regards, tom lane

view thread (49+ messages)

Message-ID: <13487.1589485526@sss.pgh.pa.us>
Permalink:  ../13487.1589485526@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/13487.1589485526@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, masao.fujii@oss.nttdata.com, tomas.vondra@2ndquadrant.com, alvherre@2ndquadrant.com, masahiko.sawada@2ndquadrant.com, tsunakawa.takay@fujitsu.com
  Subject: Re: SLRU statistics
  In-Reply-To: <13487.1589485526@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox