pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: automating pg_config.h.win32 maintenance
Date: Thu, 19 Dec 2019 08:31:05 +0100
Message-ID: <78e64ab4-ff4a-0613-660c-d6429ad8d621@2ndquadrant.com> (raw)
In-Reply-To: <20191219035924.GE4202@paquier.xyz>
References: <1441b834-f434-e0bf-46ed-9c4d5c29c2d4@2ndquadrant.com>
	<594b0e2a-6343-039a-1bac-a3ec7e74f2bf@iki.fi>
	<20191213134416.GB103520@paquier.xyz>
	<21839.1576245392@sss.pgh.pa.us>
	<2ccaf97f-5bdc-cc9c-5441-706469642776@2ndquadrant.com>
	<20191217063038.GM2344@paquier.xyz>
	<ebe2ccfe-ab5b-f7e2-242d-988daf594346@2ndquadrant.com>
	<20191219035924.GE4202@paquier.xyz>

On 2019-12-19 04:59, Michael Paquier wrote:
> On Tue, Dec 17, 2019 at 11:56:17AM +0100, Peter Eisentraut wrote:
>> Yeah, good idea.  Attached patch is refactored so all three header files
>> managed by AC_CONFIG_HEADERS are processed the same way.
> 
> Looks good.  I just have one comment.
> 
> +   # XXX
> +   open(my $f, '>>', 'src/include/pg_config.h')
> +     || confess "Could not write to src/include/pg_config.h\n";
> +   print $f "\n";
> +   print $f "#define VAL_CONFIGURE \""
> +     . $self->GetFakeConfigure() . "\"\n";
> +   close($f);
> 
> This part needs a comment.  Like it is the equivalent of what
> src/common/'s Makefile does or something like that?

This was meant to be addressed by 
<https://www.postgresql.org/message-id/flat/6e457870-cef5-5f1d-b57c-fc89cfb8a788%402ndquadrant.com;, 
but that discussion has not concluded yet.  Perhaps it makes more sense 
in this context.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (13+ messages)  latest in thread

Message-ID: <78e64ab4-ff4a-0613-660c-d6429ad8d621@2ndquadrant.com>
Permalink:  ../78e64ab4-ff4a-0613-660c-d6429ad8d621@2ndquadrant.com/
Also on:    postgresql.org/message-id/78e64ab4-ff4a-0613-660c-d6429ad8d621@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, hlinnaka@iki.fi
  Subject: Re: automating pg_config.h.win32 maintenance
  In-Reply-To: <78e64ab4-ff4a-0613-660c-d6429ad8d621@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox