From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Ideriha, Takeshi <ideriha.takeshi@jp.fujitsu.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: performance issue in remove_from_unowned_list()
Date: Wed, 6 Mar 2019 20:43:25 +0100
Message-ID: <7a449e8e-4e8b-46ce-4592-b7db9912b89f@2ndquadrant.com> (raw)
In-Reply-To: <CA+TgmobavePOgpAvBar6Ej2AsPMvcHgaqkFgsuCqBgibr45L8g@mail.gmail.com>
References: <91454a24-f8dc-f806-f499-79580a4f5bb8@2ndquadrant.com>
<20190306185250.GA18515@alvherre.pgsql>
<CA+TgmobavePOgpAvBar6Ej2AsPMvcHgaqkFgsuCqBgibr45L8g@mail.gmail.com>
On 3/6/19 8:04 PM, Robert Haas wrote:
> On Wed, Mar 6, 2019 at 1:53 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>> On 2019-Feb-08, Tomas Vondra wrote:
>>> I'm wondering if we should just get rid of all such optimizations, and
>>> make the unowned list doubly-linked (WIP patch attached, needs fixing
>>> the comments etc.).
>>
>> +1 for that approach.
>
> +1 for me, too.
>
>> Did you consider using a dlist?
>
> Maybe that is worthwhile, but this is a smaller change, which I think
> should count for quite a bit. Nothing keeps somebody from doing the
> dlist change as a separate patch, if desired.
>
Yeah, although now that I think about it I wouldn't expect the dlist
version to be much more complicated. We access next_unowned_reln on two
or three places, IIRC, so switching to dlist would be trivial I think.
What worries me more is that I observe the opposite behavior than what's
described in comment for b4166911 (which is from 2018, so not that old)
and 279628a0a7 (from 2013). So what changed since then? Seems fishy ...
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, robertmhaas@gmail.com, alvherre@2ndquadrant.com, ideriha.takeshi@jp.fujitsu.com, pgsql-hackers@lists.postgresql.org
Subject: Re: performance issue in remove_from_unowned_list()
In-Reply-To: <7a449e8e-4e8b-46ce-4592-b7db9912b89f@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox