From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: stepan rutz <stepan.rutz@gmx.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Detoasting optionally to make Explain-Analyze less misleading
Date: Thu, 2 Nov 2023 18:49:34 +0100
Message-ID: <7b7d46b1-d6f7-eb10-55c9-aa45fce57781@enterprisedb.com> (raw)
In-Reply-To: <03f952d6-b773-be93-e5d5-8f9ea9c2d461@gmx.de>
References: <ca0adb0e-fa4e-c37e-1cd7-91170b18cae1@gmx.de>
<CAEze2WhXYCJ8=ZBTbRTp9rGbvju9LK6UO7hodECKWgU-_a==aw@mail.gmail.com>
<2802772.1694532399@sss.pgh.pa.us>
<ce7edfd9-dcc5-2203-5ce5-051ca229b75a@gmx.de>
<03f952d6-b773-be93-e5d5-8f9ea9c2d461@gmx.de>
Hi,
On 9/15/23 22:09, stepan rutz wrote:
> Hi,
>
> please see a revised version yesterday's mail. The patch attached now
> provides the following:
>
> EXPLAIN(ANALYZE,SERIALIZE)
>
> and
>
> EXPLAIN(ANALYZE,SERIALIZEBINARY)
>
I haven't looked at the patch in detail yet, but this option name looks
a bit strange/inconsistent. Either it should be SERIALIZE_BINARY (to
match other multi-word options), or maybe there should be just SERIALIZE
with a parameter to determine text/binary (like FORMAT, for example).
So we'd do either
EXPLAIN (SERIALIZE)
EXPLAIN (SERIALIZE TEXT)
to get serialization to text (which I guess 99% of people will do), or
EXPLAIN (SERIALIZE BINARY)
to get binary.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@enterprisedb.com, stepan.rutz@gmx.de, tgl@sss.pgh.pa.us, boekewurm+postgres@gmail.com
Subject: Re: Detoasting optionally to make Explain-Analyze less misleading
In-Reply-To: <7b7d46b1-d6f7-eb10-55c9-aa45fce57781@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox