pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: bt21masumurak <bt21masumurak@oss.nttdata.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Improve the HINT message of the ALTER command for postgres_fdw
Date: Wed, 27 Oct 2021 01:04:02 +0900
Message-ID: <7dec8d9c-57d3-5f8b-8f5e-42febe1e13d2@oss.nttdata.com> (raw)
In-Reply-To: <CALj2ACU4FNWJ694AHXay3AG+xawRqd9q8w+bw9BR+CUNiOatFg@mail.gmail.com>
References: <557d06cebe19081bfcc83ee2affc98d3@oss.nttdata.com>
	<CALj2ACUkZ9FWZA0XgjBeMX-M_Pg2Z=xhvFsy39X6699jDWr5xw@mail.gmail.com>
	<250E9750-57EA-45BA-82A4-787CC61F7309@yesql.se>
	<46864d7a8ca6c2faeb2f9a7a401d47c0@oss.nttdata.com>
	<595194b4-20e1-58a5-4413-c0c7a1aee004@oss.nttdata.com>
	<CALj2ACU7XhadSLpT1x3988RY5ryZRGqo+vwRVF+zmaedzmhi2A@mail.gmail.com>
	<4dbda741-2e88-fd07-c2a6-396d776ccf20@oss.nttdata.com>
	<CALj2ACU_hHxz=Jdfsx6-eRyN872bYfec_gtLb130Umef=oXhQw@mail.gmail.com>
	<33141684-a9bd-aea8-e05c-2826411c70fd@oss.nttdata.com>
	<CALj2ACXxepgwujDzOk3w93kSz5c6j79GYubE1ng1_-y1c2Jt7w@mail.gmail.com>
	<29298fbf-6aec-7700-5cff-74e21d5d0e2e@oss.nttdata.com>
	<CALj2ACU4FNWJ694AHXay3AG+xawRqd9q8w+bw9BR+CUNiOatFg@mail.gmail.com>



On 2021/10/25 21:27, Bharath Rupireddy wrote:
> On Mon, Oct 25, 2021 at 4:36 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>> On 2021/10/25 16:44, Bharath Rupireddy wrote:
>>> Yeah, let's focus on fixing the hint message here and the
>>> alter_foreign_data_wrapper_options_v3.patch LGTM.
>>
>> Thanks! But since v3 changed the error codes, I got rid of those
>> changes and made v4 patch. Attached.
> 
> That's okay as we plan to deal with the error code stuff separately.
> 
>>> Why didn't we have a test case for file_fdw? It looks like the
>>> file_fdw contrib module doesn't have any test cases in its sql
>>> directory. I'm not sure if the module code is being covered in
>>> someother tests.
>>
>> You can see the regression test for file_fdw,
>> in contrib/file_fdw/input and output directories.
> 
> I missed it. Thanks. I see that there are already test cases covering
> error message with hint - "There are no valid options in this
> context."
> 
> The v4 patch LGTM.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (14+ messages)

Message-ID: <7dec8d9c-57d3-5f8b-8f5e-42febe1e13d2@oss.nttdata.com>
Permalink:  ../7dec8d9c-57d3-5f8b-8f5e-42febe1e13d2@oss.nttdata.com/
Also on:    postgresql.org/message-id/7dec8d9c-57d3-5f8b-8f5e-42febe1e13d2@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, bharath.rupireddyforpostgres@gmail.com, bt21masumurak@oss.nttdata.com, daniel@yesql.se
  Subject: Re: Improve the HINT message of the ALTER command for postgres_fdw
  In-Reply-To: <7dec8d9c-57d3-5f8b-8f5e-42febe1e13d2@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox