pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Vitaly Burovoy <vitaly.burovoy@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: identity columns
Date: Tue, 18 Apr 2017 11:51:50 -0400
Message-ID: <7e8fafb2-1949-fd97-cb57-fb1a3fe0ed6e@2ndquadrant.com> (raw)
In-Reply-To: <CAKOSWN=hUQWwyCJS8a3gTTUkvMkeg2iwSCCs=df0OYxJ_6H0kA@mail.gmail.com>
References: <6adbacbf-73bc-dd1a-2033-63409180fd18@2ndquadrant.com>
	<ed41b243-63b2-f287-e7b0-8b2ac7266d66@2ndquadrant.com>
	<CAKOSWNnMp0sKZzcX0zSKJOTSb1Fas02+xTW=kvGMu2NhRiOAbg@mail.gmail.com>
	<ec772da8-3443-b39d-e25e-138ef01a71c1@2ndquadrant.com>
	<CAKOSWNnXmM6YBXNzGnXtZQMPjDgJF+a3Wx53Wzmrq5wqDyRX7Q@mail.gmail.com>
	<c05eefac-0b55-74df-6343-71d232c15bc5@2ndquadrant.com>
	<CAKOSWNmRm0ydv1Yp8OzZ_GPh6Kfyhk+o-fxRb6onGfp433afFA@mail.gmail.com>
	<06a416db-e35b-36d1-7e2f-0affdee24745@2ndquadrant.com>
	<CAKOSWN=U0wfqjPuUbSEMAn_dcP7QnD_U0KskYf7OVhkVqs8CXA@mail.gmail.com>
	<4b1d703f-818f-00bf-4169-3279af377f3d@2ndquadrant.com>
	<CAKOSWNnxgYCVoNbmr2reMvwzQzyzgXMZn8F5JQhvkdFs73ae2g@mail.gmail.com>
	<59d8e32a-14de-6f45-c2b0-bb52e4a7522d@2ndquadrant.com>
	<CAKOSWNnLfPJE4b0_onw42QD64AzC7UESHDqK8sP2PAYERktOXQ@mail.gmail.com>
	<21ab7425-ae33-b0af-4177-f2ba88acd93a@2ndquadrant.com>
	<CAKOSWN=hUQWwyCJS8a3gTTUkvMkeg2iwSCCs=df0OYxJ_6H0kA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 4/7/17 01:26, Vitaly Burovoy wrote:
> I've implement SET GENERATED ... IF NOT EXISTS. It must be placed
> before other SET options but fortunately it conforms with the
> standard.
> Since that form always changes the sequence behind the column, I
> decided to explicitly write "[NO] CACHE" in pg_dump.
> 
> As a plus now it is possible to rename the sequence behind the column
> by specifying SEQUENCE NAME in SET GENERATED.
> 
> I hope it is still possible to get rid of the "ADD GENERATED" syntax.

I am still not fond of this change.  There is precedent all over the
place for having separate commands for creating a structure, changing a
structure, and removing a structure.  I don't understand what the
problem with that is.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (55+ messages)  latest in thread

Message-ID: <7e8fafb2-1949-fd97-cb57-fb1a3fe0ed6e@2ndquadrant.com>
Permalink:  ../7e8fafb2-1949-fd97-cb57-fb1a3fe0ed6e@2ndquadrant.com/
Also on:    postgresql.org/message-id/7e8fafb2-1949-fd97-cb57-fb1a3fe0ed6e@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, vitaly.burovoy@gmail.com
  Subject: Re: identity columns
  In-Reply-To: <7e8fafb2-1949-fd97-cb57-fb1a3fe0ed6e@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox