From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Michael Paquier <michael@paquier.xyz>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_receivewal documentation
Date: Wed, 17 Jul 2019 13:59:55 -0400
Message-ID: <7eaf748c-3f40-c994-0eb3-7d87709588d0@redhat.com> (raw)
In-Reply-To: <20190717080424.GB20614@paquier.xyz>
References: <20190710142421.GA28387@alvherre.pgsql>
<54779de5-f922-c0cf-629d-b582eded7265@redhat.com>
<20190716050555.GA1439@paquier.xyz>
<ebed4b9043b222d486ea3f0e44e7dcd242a80781.camel@cybertec.at>
<65c3ecdf-8995-34cb-83c4-50068877e632@redhat.com>
<20190717013835.GA2130@paquier.xyz>
<44e51f9f60abb872854879c91da0ed3b67a6ba95.camel@cybertec.at>
<20190717080424.GB20614@paquier.xyz>
Hi,
On 7/17/19 4:04 AM, Michael Paquier wrote:
>> How about adding "or priority-based" after "quorum-based"?
>
> I would be fine with that for the first part. I am not sure of what a
> good formulation would be for the second part of the sentence. Now it
> only refers to quorum, but with priority sets that does not apply.
> And I am not sure what "won't count towards the quorum" actually
> means.
Maybe something like the attached ? Although it doesn't help we need to
include <literal>on</literal> as well...
Best regards,
Jesper
Attachments:v6_pgreceivewal-doc.patch (text/x-patch, 1.8K) download
From f1ec4f9e715c798440288bb4e5c97100bf4efacc Mon Sep 17 00:00:00 2001
From: jesperpedersen <jesper.pedersen@redhat.com>
Date: Tue, 9 Jul 2019 13:14:25 -0400
Subject: [PATCH] Highlight that pg_receivewal doesn't apply WAL, and as such
synchronous-commit needs to be remote_write or lower.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Authors: Álvaro Herrera, Laurenz Albe and Jesper Pedersen
Review-by: Álvaro Herrera, Laurenz Albe and Jesper Pedersen
---
doc/src/sgml/ref/pg_receivewal.sgml | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/doc/src/sgml/ref/pg_receivewal.sgml b/doc/src/sgml/ref/pg_receivewal.sgmlindex 0506120c00..254315c6bf 100644--- a/doc/src/sgml/ref/pg_receivewal.sgml+++ b/doc/src/sgml/ref/pg_receivewal.sgml@@ -207,6 +207,19 @@ PostgreSQL documentation
server as a synchronous standby, to ensure that timely feedback is
sent to the server.
</para>
++ <para>+ Note that while WAL will be flushed with this setting,+ <application>pg_receivewal</application> never applies it, so+ <xref linkend="guc-synchronous-commit"/> must not be set to+ <literal>remote_apply</literal> or <literal>on</literal>+ if <application>pg_receivewal</application> is the only synchronous standby.+ Similarly, if <application>pg_receivewal</application> is part of a+ priority-based synchronous replication setup (<literal>FIRST</literal>),+ or a quorum-based setup (<literal>ANY</literal>) it won't count towards+ the policy specified if <xref linkend="guc-synchronous-commit"/> is+ set to <literal>remote_apply</literal> or <literal>on</literal>.+ </para>
</listitem>
</varlistentry>
--
2.21.0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jesper.pedersen@redhat.com, michael@paquier.xyz, laurenz.albe@cybertec.at, alvherre@2ndquadrant.com
Subject: Re: pg_receivewal documentation
In-Reply-To: <7eaf748c-3f40-c994-0eb3-7d87709588d0@redhat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox