From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: crash in pg_identify_object_as_address
Date: Mon, 18 Feb 2019 17:13:27 -0500
Message-ID: <8009.1550528007@sss.pgh.pa.us> (raw)
In-Reply-To: <20190218202743.GA12392@alvherre.pgsql>
References: <20190218202743.GA12392@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I just came across a crash while debugging some corrupted system
> catalogs; pg_identify_object_as_address fails to cope with some NULL
> input, causing a crash. Attached patch fixes it. Naturally, the output
> array will contain NULL members in the output, but that's better than
> crashing ...
Hm, does this overlap with Paquier's much-delayed patch in
https://commitfest.postgresql.org/22/1947/
?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: crash in pg_identify_object_as_address
In-Reply-To: <8009.1550528007@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox