From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Simon Riggs <simon.riggs@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Make name optional in CREATE STATISTICS
Date: Fri, 22 Jul 2022 23:54:27 -0400
Message-ID: <803080.1658548467@sss.pgh.pa.us> (raw)
In-Reply-To: <YttqI6O64wDxGn0K@paquier.xyz>
References: <YtnzFv3/jyVjRrkP@paquier.xyz>
<20220722130646.3da5oh7tgz5qgooi@alvherre.pgsql>
<YttqI6O64wDxGn0K@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> I have just looked at 83011ce, and got what you've done here. You
> have thrown away reindex_target_multitable and added three parts for
> SCHEMA, DATABASE and SYSTEM instead with their own options, enforcing
> the restriction on CONCURRENTLY at the end of REINDEX SYSTEM in the
> parser rather than indexcmds.c.
That does not seem like an improvement. In v15:
regression=# REINDEX SYSTEM CONCURRENTLY db;
ERROR: cannot reindex system catalogs concurrently
As of HEAD:
regression=# REINDEX SYSTEM CONCURRENTLY db;
ERROR: syntax error at or near "CONCURRENTLY"
LINE 1: REINDEX SYSTEM CONCURRENTLY db;
^
That is not a very helpful error, not even if the man page
doesn't show the syntax as legal.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, alvherre@alvh.no-ip.org, dean.a.rasheed@gmail.com, boekewurm+postgres@gmail.com, simon.riggs@enterprisedb.com
Subject: Re: Make name optional in CREATE STATISTICS
In-Reply-To: <803080.1658548467@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox