From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: samay sharma <smilingsamay@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: Inconsistencies around defining FRONTEND
Date: Tue, 23 Aug 2022 17:56:23 -0400
Message-ID: <806688.1661291783@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoZZ3n5-RB83e8oC7BJW9DuGSCXe+1cB0ApqNV80FZqkbw@mail.gmail.com>
References: <20220820194550.725755r6fj2ro3rx@awork3.anarazel.de>
<CA+TgmoZZ3n5-RB83e8oC7BJW9DuGSCXe+1cB0ApqNV80FZqkbw@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> Actually, I think we could fix these pretty easily too. See attached.
Hmm, do these headers still pass headerscheck/cpluspluscheck?
I might quibble a bit with the exact placement of the #ifndef FRONTEND
tests, but overall this looks pretty plausible.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andres@anarazel.de, peter.eisentraut@enterprisedb.com, noah@leadboat.com, smilingsamay@gmail.com, byavuz81@gmail.com
Subject: Re: Inconsistencies around defining FRONTEND
In-Reply-To: <806688.1661291783@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox