pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Chao Li <li.evan.chao@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Fabrizio Mello <fabrizio@planetscale.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Fix failing assert in deferred constraint trigger
Date: Fri, 11 Sep 2026 10:32:34 +0800
Message-ID: <8080BBBA-302F-4454-9A20-9535A6F45C7D@gmail.com> (raw)
In-Reply-To: <CAHGQGwGvWYHZekXZZ-u94yhtTj5W-iZdG1BwXDKTLTWmCS3xhA@mail.gmail.com>
References: <CABo-N97AeMbWuYTWg-3=2DkTR3EkvS+Ft=yEaWB181STsR1mBg@mail.gmail.com>
	<CAHGQGwE46gHsZjJhDgOVBJORQ96KeU2EHraL_PkHiCnkiKMPKw@mail.gmail.com>
	<CAHGQGwGvWYHZekXZZ-u94yhtTj5W-iZdG1BwXDKTLTWmCS3xhA@mail.gmail.com>



> On Sep 11, 2026, at 09:44, Fujii Masao <masao.fujii@gmail.com> wrote:
> 
> On Wed, Sep 9, 2026 at 12:51 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>> One comment: isn't it be better to add a test for exception handling
>> in a deferred constraint trigger at COMMIT? For example, in triggers.sql:
> 
> I've added this test. Attached is the updated version of the patch.
> 
> BTW, I found that Patrick Reynolds <patrick@piki.org> is listed in the
> From field of the patch. Does that mean he is the author of the patch,
> rather than you? I'm just asking because I need to know who to list in the
> Author tag of the commit message.
> 
> Regards,
> 
> -- 
> Fujii Masao
> <v2-0001-Fix-failing-assert-in-deferred-constraint-trigger.patch>

V2 LGTM.

One nitpick is that, the fix covers both COMMIT and PREPARE TRANSACTION, but v2 only adds a regression test for the COMMIT case. Should we test both paths?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/










view thread (11+ messages)  latest in thread

Message-ID: <8080BBBA-302F-4454-9A20-9535A6F45C7D@gmail.com>
Permalink:  ../8080BBBA-302F-4454-9A20-9535A6F45C7D@gmail.com/
Also on:    postgresql.org/message-id/8080BBBA-302F-4454-9A20-9535A6F45C7D@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: li.evan.chao@gmail.com, masao.fujii@gmail.com, fabrizio@planetscale.com
  Subject: Re: Fix failing assert in deferred constraint trigger
  In-Reply-To: <8080BBBA-302F-4454-9A20-9535A6F45C7D@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox