From: Tom Lane <tgl@sss.pgh.pa.us>
To: Anton A. Melnikov <aamelnikov@inbox.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [BUG] pg_upgrade test fails from older versions.
Date: Sun, 18 Dec 2022 20:56:48 -0500
Message-ID: <819272.1671415008@sss.pgh.pa.us> (raw)
In-Reply-To: <49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru>
References: <49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru>
"Anton A. Melnikov" <aamelnikov@inbox.ru> writes:
> 2) In 60684dd83 and b5d63824 there are two changes in the set of specific privileges.
> The thing is that in the privileges.sql test there is REVOKE DELETE command
> which becomes pair of REVOKE ALL and GRANT all specific privileges except DELETE
> in the result dump. Therefore, any change in the set of specific privileges will lead to
> a non-zero dumps diff.
> To avoid this, i propose to replace any specific GRANT and REVOKE in the result dumps with ALL.
> This also made in the patch attached.
Isn't that likely to mask actual bugs?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, aamelnikov@inbox.ru
Subject: Re: [BUG] pg_upgrade test fails from older versions.
In-Reply-To: <819272.1671415008@sss.pgh.pa.us>
References: <49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru> <819272.1671415008@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox