pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Antonin Houska <ah@cybertec.at>
To: Bruce Momjian <bruce@momjian.us>
Cc: tgl@sss.pgh.pa.us
Cc: andres@anarazel.de
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: xl_heap_header alignment?
Date: Sat, 22 Aug 2020 21:00:15 +0200
Message-ID: <81971.1598122815@antos> (raw)
In-Reply-To: <81794.1598122134@antos>
References: <21643.1595353537@antos>
	<5A0F3128-D990-4431-9E97-793CD99FF11E@anarazel.de>
	<1058724.1595356403@sss.pgh.pa.us>
	<22193.1595393913@antos>
	<20200822004048.GO13363@momjian.us>
	<81794.1598122134@antos>

Antonin Houska <ah@cybertec.at> wrote:

> If the comment tells that t_hoff can be computed (i.e. it's no necessary to
> include it in the structure), I think the comment should tell why it's yet
> included. Maybe something about "historical reasons"? Perhaps we can say that
> the storage used to be free due to padding, and that it's no longer so, but
> it's still "cheap", so it's not worth to teach the REDO functions to compute
> the value.

I've received some more replies to your email as soon as I had replied. I
don't insist on my proposal, just go ahead with your simpler changes.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com





view thread (11+ messages)  latest in thread

Message-ID: <81971.1598122815@antos>
Permalink:  ../81971.1598122815@antos/
Also on:    postgresql.org/message-id/81971.1598122815@antos

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ah@cybertec.at, bruce@momjian.us, tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: xl_heap_header alignment?
  In-Reply-To: <81971.1598122815@antos>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox