From: torikoshia <torikoshia@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: gkokolatos@protonmail.com, kasahara.tatsuhito@gmail.com, Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Get memory contexts of an arbitrary backend process
Date: Tue, 06 Apr 2021 10:57:01 +0900
Message-ID: <8205c0edb46ae848bcf07635ac2cc7ee@oss.nttdata.com> (raw)
In-Reply-To: <c899e0d4-ac82-1f4e-bbd3-41c40b33f0e9@oss.nttdata.com>
References: <bbecd722d4f8e261b350186ac4bf68a7@oss.nttdata.com>
<1f259e90-08c8-2202-be66-f7ee05d22cd2@oss.nttdata.com>
<f6f6373ae200c8a0e7466e4de9ca65eb@oss.nttdata.com>
<20210331.151612.259240960686480846.horikyota.ntt@gmail.com>
<65fbf059-bcff-1585-59a1-1ec6a6f5ac75@oss.nttdata.com>
<e1fdbdcae9fac88cf4cd4b552bc4a741@oss.nttdata.com>
<CALNJ-vQ=x-9AgsVA5fQH_LZQABr+G3ATCPoWE-WFmwjd9Lhp3w@mail.gmail.com>
<6ab7b7f1-8dca-288f-5578-0a0716567341@oss.nttdata.com>
<bd216370d915116da8c3cba6537f78dc@oss.nttdata.com>
<c899e0d4-ac82-1f4e-bbd3-41c40b33f0e9@oss.nttdata.com>
On 2021-04-06 00:08, Fujii Masao wrote:
> On 2021/04/05 21:03, torikoshia wrote:
>> On 2021-04-05 12:59, Fujii Masao wrote:
>>> On 2021/04/05 12:20, Zhihong Yu wrote:
>>
>> Thanks for reviewing!
>>
>>>> + * On receipt of this signal, a backend sets the flag in the signal
>>>> + * handler, and then which causes the next CHECK_FOR_INTERRUPTS()
>>
>>>> I think the 'and then' is not needed:
>>
>> Although I wonder either would be fine, removed the words.
>>
>>>> + * This is just a warning so a loop-through-resultset will
>>>> not abort
>>>> + * if one backend logged its memory contexts during the run.
>>>>
>>>> The pid given by arg 0 is not a PostgreSQL server process. Which
>>>> other backend could it be ?
>>>
>>> This is the comment that I added wrongly. So the comment should be
>>> "This is just a warning so a loop-through-resultset will not abort
>>> if one backend terminated on its own during the run.",
>>> like pg_signal_backend(). Thought?
>>
>> +1.
>>
>> Attached v10 patch.
>
> Thanks for updating the patch!
>
> I updated the patch as follows. Could you check the attached patch?
Thanks a lot!
I don't have any objections to your improvements.
Regards,
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: torikoshia@oss.nttdata.com, masao.fujii@oss.nttdata.com, zyu@yugabyte.com, horikyota.ntt@gmail.com, tgl@sss.pgh.pa.us, craig@2ndquadrant.com
Subject: Re: Get memory contexts of an arbitrary backend process
In-Reply-To: <8205c0edb46ae848bcf07635ac2cc7ee@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox