From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>
To: Noah Misch <noah@leadboat.com>
To: pgsql-hackers@postgresql.org
Subject: Re: AIX support - alignment issues
Date: Tue, 5 Jul 2022 08:13:21 +0200
Message-ID: <82efc9f6-d8d6-7226-b167-b807dce568cd@enterprisedb.com> (raw)
In-Reply-To: <20220705053150.tgr5vuiq6olnx7g2@awork3.anarazel.de>
References: <20220702183354.a6uhja35wta7agew@alap3.anarazel.de>
<20220705053150.tgr5vuiq6olnx7g2@awork3.anarazel.de>
On 05.07.22 07:31, Andres Freund wrote:
> On 2022-07-02 11:33:54 -0700, Andres Freund wrote:
>> If we decide we want to continue supporting AIX we should bite the bullet and
>> add a 64bit-int TYPALIGN_*. It might be worth to translate that to bytes when
>> building tupledescs, so we don't need more branches (reducing them compared to
>> today).
>
> I just thought an easier way - why don't we introduce a 'catalog_double'
> that's defined to be pg_attribute_aligned(whatever-we-need) on AIX? Then we
> can get rid of the manually enforced alignedness and we don't need to contort
> catalog order.
Isn't the problem that on AIX, double and int64 have different alignment
requirements, and we just check the one for double and apply it to
int64? That ought to be fixable by two separate alignment checks in
configure and a new alignment letter for pg_type.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, andres@anarazel.de, noah@leadboat.com
Subject: Re: AIX support - alignment issues
In-Reply-To: <82efc9f6-d8d6-7226-b167-b807dce568cd@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox