agora inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed

From: Antonin Houska <ah@cybertec.at>
To: alvherre@kurilemu.de
Cc: Radim Marek <radim@boringsql.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: REPACK (CONCURRENTLY) might keep dropped-column data
Date: Wed, 30 Sep 2026 16:41:45 +0200
Message-ID: <83138.1790779305@localhost> (raw)
In-Reply-To: <arz09-sHiSl3qBN0@alvherre.pgsql>
References: <arz09-sHiSl3qBN0@alvherre.pgsql>

Álvaro Herrera <alvherre@kurilemu.de> wrote:

> Hello Radim, thanks for testing!
> 
> On 2026-Sep-30, Radim Marek wrote:
> 
> > Aha, so on my way to office I started thinking and got more silly ideas,
> > and now can confirm this is more widespread than logical subscriber use
> > case.
> 
> Oh, thanks for the simplified test case.  We can fix this easily by
> setting the column to null in the tuple to write out, as in the attached
> patch.

I thought of fixing this on the decoding worker side so that the dropped
attribute values are not even written to the output file. However that would
require one more forming of the tuple.

> The adjust_toast_pointers() function should perhaps be renamed,
> and the comment rewritten, since it's no longer just about toast ...
> I didn't do that though.

Maybe prepare_concurrent_update(), as it's called right before
apply_concurrent_update()?

BTW, I've noticed now that the 'relation' argument of adjust_toast_pointers()
isn't used anymore. Perhaps it was used before the tuple slots have been
introduced into the function.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

view thread (7+ messages)  latest in thread

Message-ID: <83138.1790779305@localhost>
Permalink:  ../83138.1790779305@localhost/
Also on:    postgresql.org/message-id/83138.1790779305@localhost

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ah@cybertec.at, alvherre@kurilemu.de, radim@boringsql.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: REPACK (CONCURRENTLY) might keep dropped-column data
  In-Reply-To: <83138.1790779305@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox