agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Alvaro Herrera <alvherre@kurilemu.de>
To: Antonin Houska <ah@cybertec.at>
Cc: Radim Marek <radim@boringsql.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: REPACK (CONCURRENTLY) might keep dropped-column data
Date: Sat, 3 Oct 2026 15:48:15 +0200
Message-ID: <asEEA-lMrIQpGZMN@alvherre.pgsql> (raw)
In-Reply-To: <83138.1790779305@localhost>
On 2026-Sep-30, Antonin Houska wrote:
> Álvaro Herrera <alvherre@kurilemu.de> wrote:
> > The adjust_toast_pointers() function should perhaps be renamed,
> > and the comment rewritten, since it's no longer just about toast ...
> > I didn't do that though.
>
> Maybe prepare_concurrent_update(), as it's called right before
> apply_concurrent_update()?
Thanks, I used this name.
> BTW, I've noticed now that the 'relation' argument of adjust_toast_pointers()
> isn't used anymore. Perhaps it was used before the tuple slots have been
> introduced into the function.
Good catch. Removed. Yes, it was used in 0005 with v36 you submitted
[1], but it disappeared when I posted v43 [2], which is when I rewrote
it to use tuple slots.
[1] https://www.postgresql.org/message-id/87648.1772217509@localhost
[2] https://www.postgresql.org/message-id/202603191855.fzsgsnyzfvpt@alvherre.pgsql
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"El número de instalaciones de UNIX se ha elevado a 10,
y se espera que este número aumente" (UPM, 1972)
view thread (7+ messages)
Message-ID: <asEEA-lMrIQpGZMN@alvherre.pgsql>
Permalink: ../asEEA-lMrIQpGZMN@alvherre.pgsql/
Also on: postgresql.org/message-id/asEEA-lMrIQpGZMN@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, ah@cybertec.at, radim@boringsql.com, pgsql-hackers@lists.postgresql.org
Subject: Re: REPACK (CONCURRENTLY) might keep dropped-column data
In-Reply-To: <asEEA-lMrIQpGZMN@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox