public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Steele <[email protected]>
To: Hüseyin Demir <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: Improve checks for GUC recovery_target_xid
Date: Tue, 17 Mar 2026 14:36:49 +0000 (UTC)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAB5wL7Y=BK7jf7J_shotdBqE9cVy4wgZhk1QuFdoeGonDQwaZg@mail.gmail.com>
References: <[email protected]>
	<CAHGQGwG44vZbSoBmg076G+xkR6n=Tj2=q+fVkfP7yEsyF1daFA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAHGQGwEYYad_=fiBkt8HZ=aknXoCUx=2cL7UwSQSYM3nozHMyg@mail.gmail.com>
	<[email protected]>
	<CAHGQGwGuyb--9MBJX__FVJH1=ny0Jh1H+j0Z-_z-28VZy9hK8g@mail.gmail.com>
	<[email protected]>
	<CAHGQGwEhf9byyjhcDEMAd0kPkTdJsO0-HNTnX6Hqs6puBij3-g@mail.gmail.com>
	<[email protected]>
	<CAHGQGwFuXjy7wAkzeDg0cpwsLweyjNO1tACgUWtNdCDtwxZ9hQ@mail.gmail.com>
	<[email protected]>
	<CAB5wL7Y=BK7jf7J_shotdBqE9cVy4wgZhk1QuFdoeGonDQwaZg@mail.gmail.com>

Hi,

On 3/16/26 14:44, Hüseyin Demir wrote:
> 
> David Steele <[email protected]>, 6 Mar 2026 Cum, 16:01 tarihinde şunu yazdı:
>>
>> On 3/6/26 14:05, Fujii Masao wrote:
>>> On Fri, Mar 6, 2026 at 3:15 PM Michael Paquier <[email protected]> wrote:
>>>>
>>>> On Fri, Mar 06, 2026 at 12:04:00AM +0900, Fujii Masao wrote:
>>>>> Thanks for the patch! It looks good to me. Barring any objections, I
>>>>> will commit it.
>>>>
>>>> Thanks.
>>>
>>> I've pushed the patch. Thanks!
>>
>> Thank you and great idea on ALTER SYSTEM. I've been hesitant to add more
>> tests in this area because they are so expensive but now I feel much
>> better about it. But that's the last for this CF since there is more
>> important stuff to be done.
>>
>> Regards,
>> -David
> 
> I tried to create tests with the ALTER SYSTEM approach to validate the GUC.
> 
> You can review it if it's the correct approach or not. We can create a
> new CF record if required for the patch.

I modified the tests in the patch to use ALTER SYSTEM and that was 
committed at [1].

One of the tests (bogus) you have added here is a duplicate but the 
other one (upper bound) could be added.

You appear to be working against an old version of the master branch so 
I would recommend rebasing and then add your upper bound test following 
the test pattern we have already established.

I personally don't think the upper bound test adds a lot of value here 
since it is handled by strtou64() just like the bogus test so it will 
not extend coverage, but I'm fine with it if others are.

Regards,
-David

[1] 
https://git.postgresql.org/pg/commitdiff/bffd7130e942e2bd45153ab09e5fab70e74ece58.

view thread (20+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Improve checks for GUC recovery_target_xid
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox