From: Tom Lane <tgl@sss.pgh.pa.us>
To: Greg Stark <greg.stark@enterprisedb.com>
Cc: ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Cc: Gregory Stark <stark@enterprisedb.com>
Cc: Postgres <pgsql-hackers@postgresql.org>
Subject: Re: posix_fadvise v22
Date: Thu, 11 Dec 2008 11:29:30 -0500
Message-ID: <8347.1229012970@sss.pgh.pa.us> (raw)
In-Reply-To: <FDDBA24E-FF4D-4654-BA75-692B3BA71B97@enterprisedb.com>
References: <FDDBA24E-FF4D-4654-BA75-692B3BA71B97@enterprisedb.com>
Greg Stark <greg.stark@enterprisedb.com> writes:
>> A variable prefetch_pages is defined as "unsigned" or "int"
>> in some places. Why don't you define it only once in a header
>> and include the header in source files?
> Just... Which header?
MHO: the header that goes with the source file that is most concerned with
implementing the variable's behavior (which is also the file that should
have the actual variable definition).
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, greg.stark@enterprisedb.com, itagaki.takahiro@oss.ntt.co.jp, stark@enterprisedb.com
Subject: Re: posix_fadvise v22
In-Reply-To: <8347.1229012970@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox