From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: John Naylor <john.naylor@2ndquadrant.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: assert pg_class.relnatts is consistent
Date: Sat, 15 Feb 2020 15:25:55 -0500
Message-ID: <8403.1581798355@sss.pgh.pa.us> (raw)
In-Reply-To: <618.1581706856@sss.pgh.pa.us>
References: <20200214152926.GA7006@alvherre.pgsql>
<618.1581706856@sss.pgh.pa.us>
I wrote:
> So that leads me to the attached.
> ...
> (I agree with Alvaro's thought of shortening AddDefaultValues,
> but didn't do that here.)
Pushed both of those. I also did something with the stale comment
that Justin referred to in the initial message (it wasn't really
good practice to try to deal with both things in one thread).
I think we're done here, though maybe the difficulty of finding a clean
way to get genbki.pl to do this suggests that AddDefaultValues needs
to be redesigned. Not sure what that'd look like.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, john.naylor@2ndquadrant.com, amitlangote09@gmail.com, pryzby@telsasoft.com
Subject: Re: assert pg_class.relnatts is consistent
In-Reply-To: <8403.1581798355@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox