pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Greg Smith <gsmith@gregsmith.com>
Cc: Gregory Stark <stark@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Overhauling GUCS
Date: Fri, 06 Jun 2008 20:30:41 -0400
Message-ID: <8459.1212798641@sss.pgh.pa.us> (raw)
In-Reply-To: <Pine.GSO.4.64.0806061730410.27291@westnet.com>
References: <Pine.GSO.4.64.0806041045520.2258@westnet.com>
	<29525.1212613052@sss.pgh.pa.us>
	<48472E47.7030701@dunslane.net>
	<Pine.GSO.4.64.0806042033120.3874@westnet.com>
	<20080605162400.GF16502@alvh.no-ip.org>
	<48481CBF.6040602@enterprisedb.com>
	<48481E3A.4010306@hagander.net>
	<Pine.GSO.4.64.0806051321360.27711@westnet.com>
	<20080605174209.GL16502@alvh.no-ip.org>
	<Pine.GSO.4.64.0806051452480.27254@westnet.com>
	<20080605212129.GI14498@yugib.highrise.ca>
	<Pine.GSO.4.64.0806051725550.10475@westnet.com>
	<3F927D52-A0FD-4575-8D24-F0F70C459235@kineticode.com>
	<4848FAA6.8000903@pse-consulting.de>
	<87ej7aeuqx.fsf@oxford.xeocode.com>
	<4849137C.3040008@pse-consulting.de>
	<877id2erp6.fsf@oxford.xeocode.com>
	<48492356.4040506@pse-consulting.de>
	<1618.1212765176@sss.pgh.pa.us>
	<Pine.GSO.4.64.0806061524140.7804@westnet.com>
	<87d4muclr6.fsf@oxford.xeocode.com>
	<Pine.GSO.4.64.0806061730410.27291@westnet.com>

Greg Smith <gsmith@gregsmith.com> writes:
> On Fri, 6 Jun 2008, Gregory Stark wrote:
>> "Greg Smith" <gsmith@gregsmith.com> writes:
>>> 1) Is it worthwhile to expand the information stored in the GUC structure to
>>> make it better capable of supporting machine generation and to provide more
>>> information for tool authors via pg_settings?  The exact fields that should or
>>> shouldn't be included remains controversial; consider "default value",
>>> "per-session/runtime/restart", and "enum lists" as the list of things that are
>>> most needed there.
>> 
>> Isn't that a list of what's *already* there?

> I should have been clearer there.  Some of the items suggested are already 
> in the structure, but aren't visible via pg_settings.

Well, you can't see the default or reset values in pg_settings, only the
current value.  However, I fail to see the use of either of those for
a configure wizard.  It'll presumably be attached to a fresh connection
so the reset value is not different from the current; and any decent
wizard is going to know perfectly well what the defaults are.

> ... In others (like the 
> suggestion to add a URL to the documentation) it is actually a new field 
> being added as well as its corresponding entry in the settings view.

Offhand I would argue that we should choose the URLs in such a way that
they can be derived automatically if you know the PG version number and
GUC variable name.  (We're almost there already, except that you have
to know which section of the chapter it's in.)  So the need to have a
pg_settings column seems questionable --- seems like it would mostly
be clutter.  Perhaps instead of a view column, it would be useful to
encapsulate the algorithm as a function?  pg_variable_help_url(name)

			regards, tom lane



view thread (226+ messages)  latest in thread

Message-ID: <8459.1212798641@sss.pgh.pa.us>
Permalink:  ../8459.1212798641@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/8459.1212798641@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, gsmith@gregsmith.com, stark@enterprisedb.com
  Subject: Re: Overhauling GUCS
  In-Reply-To: <8459.1212798641@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox