public inbox for [email protected]
help / color / mirror / Atom feedFrom: Antonin Houska <[email protected]>
To: Mihail Nikalayeu <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Pg Hackers <[email protected]>
Cc: Robert Treat <[email protected]>
Subject: Re: Adding REPACK [concurrently]
Date: Mon, 19 Jan 2026 17:31:19 +0100
Message-ID: <85930.1768840279@localhost> (raw)
In-Reply-To: <23347.1768587496@localhost>
References: <[email protected]>
<11247.1767609087@localhost>
<11558.1767609632@localhost>
<141054.1767891540@localhost>
<CADzfLwU-OmxW3t3AoQo9=K7uq4G1yZ-txcetzW3jbcVxV_pJew@mail.gmail.com>
<137668.1768235610@localhost>
<CADzfLwUJSHKGxYw+vMUZ_Hr2YeuxO2Q5w13HKgUUN1725tjY5Q@mail.gmail.com>
<CADzfLwU78as45To9a=-Qkr5jEg3tMxc5rUtdKy2MTv4r_SDGng@mail.gmail.com>
<35686.1768495019@localhost>
<CADzfLwWQRAqi1EQrKFiTgXJsdz_3ZFAWkto97hsYb-bMcpwuwg@mail.gmail.com>
<23347.1768587496@localhost>
Antonin Houska <[email protected]> wrote:
> Mihail Nikalayeu <[email protected]> wrote:
>
> >Antonin Houska <[email protected]>:
> >>
> >> As the test runs pgbench with --client=30 and the default value of
> >> max_worker_processes is 8, I'm not sure this is a leak. I've increased this
> >> parameter I couldn't see the error anymore.
> >
> > Hm, as far as I remember only single repack may be executed in test (because
> > of locking on test itself and also REPACK).
>
> The only problem is that the logical decoding system needs to wait during the
> setup for all the running transactions to finish. So if REPACK (CONCURRENTLY)
> is already running, the next execution will not start until the first is done.
>
> However, that does not restrict the REPACK decoding workers from starting.
>
> >> I agree that this is due to the missing MVCC safety feature. I commented that
> >> check in the script for now.
> >
> > I don't think so. In case of non-MVCC safety we should see 0 or correct sum. But script failed with 490588...
> > But should see 500500 (if I correctly calculated sum of numbers from 1 to 1000)...
>
> I was referring to your statement "It may be 0 because non-MVCC
> safe". Regarding the non-zero values, I think I finally understand the issue
> and even could reproduce some weird behavior using debugger. Since it also
> affects logical replication, I'll provide more details (and hopefully propose
> a patch) in a separate thread early next week.
This is the report:
https://www.postgresql.org/message-id/85833.1768840165%40localhost
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
view thread (31+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <85930.1768840279@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox