From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Should contrib modules install .h files?
Date: Thu, 02 Aug 2018 19:42:31 +0100
Message-ID: <871sbgaa18.fsf@news-spur.riddles.org.uk> (raw)
In-Reply-To: <20180802182144.6qrkfct47u3s2w7t@alap3.anarazel.de>
References: <87o9enb4h7.fsf@news-spur.riddles.org.uk>
<20180731201700.zfscje7clxiljvjl@alap3.anarazel.de>
<CAH2-Wz=imVrbydSkBH95y3w7ZU7XffE7-LW0R+LjfZrXnyz-dw@mail.gmail.com>
<11978.1533073999@sss.pgh.pa.us>
<CA+TgmoZB9fVOd-8ZSWLaKX_TVAV9y0+7YrUn8vbpAPL_4XmGPw@mail.gmail.com>
<1836.1533221640@sss.pgh.pa.us>
<87lg9oaghh.fsf@news-spur.riddles.org.uk>
<25706.1533229991@sss.pgh.pa.us>
<87a7q4adnk.fsf@news-spur.riddles.org.uk>
<87600sabb2.fsf@news-spur.riddles.org.uk>
<20180802182144.6qrkfct47u3s2w7t@alap3.anarazel.de>
>>>>> "Andres" == Andres Freund <andres@anarazel.de> writes:
Tom> There's also a question of whether we need to change anything in
Tom> contrib/ so that it plays by whatever rules we set. There's an
Tom> expectation that contrib modules should be buildable with PGXS,
Tom> so they need to follow the rules.
Andrew> ... that at least all of the *_plperl transform modules in
Andrew> contrib/ fail to build with USE_PGXS already (i.e. for as long
Andrew> as they have ever existed), because they rely on
Andrew> plperl_helpers.h which is never installed anywhere, and trying
Andrew> to get it via $(top_srcdir) obviously can't work in PGXS.
Andrew> Haven't tried the python ones yet.
>> And none of the plpython transforms can even parse their makefiles
>> with USE_PGXS, let alone build, because they have an "include"
>> directive pointing into src/pl/plpython.
Andres> FWIW, I'd be perfectly on board with just burying this policy.
Andres> Designating one contrib module (or something in
Andres> src/test/examples or such) as a PGXS example, and always
Andres> building it with pgxs seems like it'd do a much better job than
Andres> the current policy.
I suggest that modules that actually _can't_ build with PGXS should have
the PGXS logic removed from their makefiles (perhaps replaced with an
error). But for the rest, it's a convenience to be able to build single
modules using USE_PGXS without having to configure the whole source tree.
--
Andrew (irc:RhodiumToad)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@tao11.riddles.org.uk, andres@anarazel.de, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, pg@bowt.ie
Subject: Re: Should contrib modules install .h files?
In-Reply-To: <871sbgaa18.fsf@news-spur.riddles.org.uk>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox