pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andreas Seltenreich <seltenreich@gmx.de>
To: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Chapman Flack <chap@anastigmatix.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [HACKERS] MERGE SQL Statement for PG11
Date: Sun, 18 Feb 2018 12:18:43 +0100
Message-ID: <87371yczqk.fsf@ansel.ydns.eu> (raw)
In-Reply-To: <CABOikdPtfpMoeWR827-fRy0Q2=3scGaRFDHY+HZ_cG0zJYV09w@mail.gmail.com>
References: <CANP8+jLdJoqjzkEdfqy_Rw43gUk08btunpJVV7Yiw=UqtOtePw@mail.gmail.com>
	<CANP8+jJgS_KoN6DDteb_9-fUzfnp7Ytm9O5VE83dGpWp1pszkg@mail.gmail.com>
	<CAH2-WznpEqdzL_sgWOHfmb9jz6612JLkhdN5YcdmdW3qX3g4Uw@mail.gmail.com>
	<CANP8+jKTuZ5NDCLkqXBm9kMeaT-jNxxhkMg+FOpLni=pwOQ=BA@mail.gmail.com>
	<CANP8+jKJee2Luip7tv4KrK8R_EP5PbOvDD+vfUpp9uBFmfK9yg@mail.gmail.com>
	<CANP8+jK8YRSCrg8m8XiRMmoy9DfvL=hUQ1SpS=+y=920evbTvg@mail.gmail.com>
	<CAFj8pRCUbOsyD5ny1UvoZciEbk3Q1YJj+gjEta=1X8dGb1cjSA@mail.gmail.com>
	<CANP8+jL86yJU0cx09DCWZVT=ZAo4JK1oqS_0s0t=WUN-FP9iaQ@mail.gmail.com>
	<CAFj8pRApqwbS9ZBf38=vg38rU90dotukx22xxV+Oe8fiCv=3Kg@mail.gmail.com>
	<CANP8+jKoE=AXPz+gMdxXgod7UO_C8OGwJ6aD+A4b5nfxLOzQrA@mail.gmail.com>
	<20180129154457.GC11613@momjian.us>
	<CANP8+jLDtMxYXJ95ffA3PYqAVfTkh3V42W9TYWAJH6PsAgOocg@mail.gmail.com>
	<495e24a5-d5bf-3ef2-ccdd-dd112c1c3a15@anastigmatix.net>
	<CANP8+j+icDb4=+zVUiRN60TAf9s9WT+6dOoWQqDu+B90xATRHA@mail.gmail.com>
	<CAFj8pRA7=C9yPJW_iG2Es-qBkZt-hSUFmF+cqZGoHU5SAPj_kw@mail.gmail.com>
	<CANP8+j+YDPtO9KsMX2ztXLxHjpmjef3ytfmhRfvK48db0o4btg@mail.gmail.com>
	<87k1vtdexn.fsf@ansel.ydns.eu>
	<CANP8+jLQ81X0dR2k2i6eOwg4226GGoTbRS6_e=6oDdmBRXwXYQ@mail.gmail.com>
	<87a7wpc5n3.fsf@ansel.ydns.eu>
	<CABOikdPtfpMoeWR827-fRy0Q2=3scGaRFDHY+HZ_cG0zJYV09w@mail.gmail.com>

Pavan Deolasee writes:

> Thanks for doing those tests. I've just sent v16a version of the patch and
> I think it fixes the issues reported so far. Can you please recheck? Please
> let me know if there are other issues detected by sqlsmith or otherwise.

I re-did the testing with merge_v16a applied to master at 7923118c16
with ad7dbee368a reverted because of conflicts.  I can confirm that the
previous testcases don't fail anymore, but sqlsmith readily triggers the
following assertion:

TRAP: FailedAssertion("!(mergeTargetRelation > 0)", File: "planner.c",
Line: 1496)

Testcase attached.

regards,
Andreas

Attachments:

  merge-v16a-trap-planner.c.sql (application/x-sql, 1.3K) download

view thread (265+ messages)  latest in thread

Message-ID: <87371yczqk.fsf@ansel.ydns.eu>
Permalink:  ../87371yczqk.fsf@ansel.ydns.eu/
Also on:    postgresql.org/message-id/87371yczqk.fsf@ansel.ydns.eu

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: seltenreich@gmx.de, pavan.deolasee@gmail.com, simon@2ndquadrant.com, pavel.stehule@gmail.com, chap@anastigmatix.net, pgsql-hackers@lists.postgresql.org
  Subject: Re: [HACKERS] MERGE SQL Statement for PG11
  In-Reply-To: <87371yczqk.fsf@ansel.ydns.eu>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox