public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dagfinn Ilmari Mannsåker <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Melanie Plageman <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: remove bits* types
Date: Mon, 30 Mar 2026 18:36:48 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <acqu7Z40kvJ4t8O8@nathan>
References: <absbX33E4eaA0Ity@nathan>
	<[email protected]>
	<acV5NYm4XBzIE50N@nathan>
	<CAAKRu_ZucXL3mLc0f-t_7giiChN9Zad2EAr9SoAqFFc95vFaOg@mail.gmail.com>
	<acqsERCb1t8OCZpG@nathan>
	<[email protected]>
	<acqu7Z40kvJ4t8O8@nathan>

Nathan Bossart <[email protected]> writes:

> On Mon, Mar 30, 2026 at 01:07:32PM -0400, Tom Lane wrote:
>> Nathan Bossart <[email protected]> writes:
>>> With Melanie's note, there are at least 4 votes in favor of this patch
>>> (Andres, me, Peter, and Melanie).  AFAICT Michael is +/-0, Álvaro and Tom
>>> are -1 (or somewhere in the vicinity), and Robert seems ambivalent.  Hm...
>> 
>> To clarify, what I said was we should either remove them or use them
>> more consistently.  I don't think 1bd6f22f4 moved the needle very
>> far towards option 2, so I'm totally fine with option 1.  Put me
>> down as +0.5.
>
> Thanks for clarifying.  Given that update and Álvaro's note upthread [0],
> I'd argue we're in rough consensus territory and can move forward with the
> patch.  If no objections materialize shortly, I'll do so.

To avoid breaking extensions, we could leave the typedefs in place with
an #ifndef guard on some symbol that's only defined when building
postgres itself, but not when building extensions (or vice versa with an
#ifdef instead).

This is used a lot in Perl for things we don't want to use in core any
more, but we don't want to break CPAN modules still using.

- ilmari

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: remove bits* types
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox