public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dagfinn Ilmari Mannsåker <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: px shi <[email protected]>
Cc: [email protected]
Subject: Re: CREATE MATERIALIZED VIEW
Date: Thu, 25 Jul 2024 16:10:37 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <ZqJnCV1pH99TUF7v@nathan>
References: <CAAccyY+Wg1Z-9tNfSwLmuZVgGOwqU5u1OP-RWcoAr2UZGuvN_w@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<ZqJjZscmd5TrTR36@nathan>
	<[email protected]>
	<ZqJnCV1pH99TUF7v@nathan>

Nathan Bossart <[email protected]> writes:

> On Thu, Jul 25, 2024 at 03:49:02PM +0100, Dagfinn Ilmari Mannsåker wrote:
>> Nathan Bossart <[email protected]> writes:
>>> However, since it looks like the feature was never actually supported in a
>>> release, and the revert has been in place for over a decade, I think it'd
>>> be reasonable to remove the tab completion now.  It looks like the folks on
>>> the 2021 thread felt similarly.
>> 
>> Keeping it in the grammar makes sense for the more specific error
>> message, but I don't think the tab completion should be suggesting bogus
>> things, regardless of whether it's the grammar or the parse analysis
>> that rejects it.
>
> Would you mind creating a commitfest entry for this one?  I'll plan on
> committing this early next week unless any objections materialize.

Done: https://commitfest.postgresql.org/49/5139/

I've taken the liberty of setting you as the committer, and the target
version to 17 even though it turns out to be an older bug, since it's
arguably a follow-on fix to the incomplete fix in c951e9042dd1.

- ilmari

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: CREATE MATERIALIZED VIEW
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox