pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PG 16 draft release notes ready
Date: Tue, 30 May 2023 11:28:24 +0100
Message-ID: <874jnut8on.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <ZHXJ522uSKnLgIzt@momjian.us>
References: <ZGaPa7M3gc2THeDJ@momjian.us>
	<878rdctb7o.fsf@wibble.ilmari.org>
	<ZHKvrWUH66Hw6H0A@momjian.us>
	<ZHXJ522uSKnLgIzt@momjian.us>

Bruce Momjian <bruce@momjian.us> writes:

> On Sat, May 27, 2023 at 09:34:37PM -0400, Bruce Momjian wrote:
>> > > This is controlled by auto_explain.log_parameter_max_length, and by
>> > > default query parameters will be logged with no length
>> > > restriction. SHOULD THIS BE MORE CLEARLY IDENTIFIED AS CONTROLLING THE
>> > > EXECUTION OF PREPARED STATEMENTS?
>> > 
>> > This is wrong, the logging applies to all query parameters, not just for
>> > prepared statements (and has nothing to do with controlling the
>> > execution thereof).  That was just the only way to test it when it was
>> > written, because psql's \bind command exist yet then.
>> 
>> I see your point.  How is this?
>> 
>> 	Allow auto_explain to log query parameters used by parameterized
>> 	statements (Dagfinn Ilmari Mannsåker)
>> 
>> 	This affects queries using server-side PRAPARE/EXECUTE
>> 	and client-side parse/bind.  Logging is controlled by
>> 	auto_explain.log_parameter_max_length;	by default query
>> 	parameters will be logged with no length restriction.
>
> Done, attached patch applied.

That works for me. Thanks!

- ilmari





view thread (141+ messages)  latest in thread

Message-ID: <874jnut8on.fsf@wibble.ilmari.org>
Permalink:  ../874jnut8on.fsf@wibble.ilmari.org/
Also on:    postgresql.org/message-id/874jnut8on.fsf@wibble.ilmari.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: ilmari@ilmari.org, bruce@momjian.us
  Subject: Re: PG 16 draft release notes ready
  In-Reply-To: <874jnut8on.fsf@wibble.ilmari.org>
  References: <ZGaPa7M3gc2THeDJ@momjian.us> <878rdctb7o.fsf@wibble.ilmari.org> <ZHKvrWUH66Hw6H0A@momjian.us> <ZHXJ522uSKnLgIzt@momjian.us> <874jnut8on.fsf@wibble.ilmari.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox