From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Logging query parmeters in auto_explain
Date: Tue, 28 Jun 2022 10:12:18 +0100
Message-ID: <87a69xkv7x.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <YrqzsLM96tEbFxeU@paquier.xyz>
References: <87ee09mohb.fsf@wibble.ilmari.org>
<Yp8D4kb2qZnhNAWJ@paquier.xyz>
<8735ggn2lf.fsf@wibble.ilmari.org>
<YqFQbYkFLF4fXuZX@paquier.xyz>
<87tu8tla5s.fsf@wibble.ilmari.org>
<Yqg9tlxk0Ghwd7Of@paquier.xyz>
<87iloml5a5.fsf@wibble.ilmari.org>
<87fsjql51e.fsf@wibble.ilmari.org>
<YrqzsLM96tEbFxeU@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Jun 27, 2022 at 12:27:57PM +0100, Dagfinn Ilmari Mannsåker wrote:
>> I forgot to mention, I also changed the order of the query and
>> parameters, so that they can more naturally be left out when no changes
>> are needed.
>
> I can see that, and I have added $node as an extra parameter of the
> routine. After putting my hands on that, it also felt a bit unnatural
> to do the refactoring of the tests and the addition of the new GUC in
> the same patch, so I have split things as the attached. The amount of
> coverage is still the same but it makes the integration of the feature
> easier to follow.
That makes sense, but I still think the query_log() function definition
should go at the end (after done_testing()), so the machinery doesn't
distract from what's actually being tested.
Also, the second paragraph of the second commit message now belongs in
the first commit (without the word "Also").
Thanks,
ilmari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: Logging query parmeters in auto_explain
In-Reply-To: <87a69xkv7x.fsf@wibble.ilmari.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox