From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Cc: kes-kes@yandex.ru
Subject: Re: mark/restore failures on unsorted merge joins
Date: Tue, 24 Nov 2020 20:45:33 +0000
Message-ID: <87blfm4hdv.fsf@news-spur.riddles.org.uk> (raw)
In-Reply-To: <296182.1606247286@sss.pgh.pa.us>
References: <87o8jn50be.fsf@news-spur.riddles.org.uk>
<125707.1606161260@sss.pgh.pa.us>
<87k0ua4p4u.fsf@news-spur.riddles.org.uk>
<293167.1606242810@sss.pgh.pa.us>
<87ft4y4lxm.fsf@news-spur.riddles.org.uk>
<296182.1606247286@sss.pgh.pa.us>
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:
>> I guess that's close enough; this should suffice then.
Tom> Looks about right. Not sure if we need to bother with a regression
Tom> test case; once that's in, it'd be hard to break it.
We could check the EXPLAIN output (since the Materialize node would show
up), but it's not easy to get stable plans since the choice of which
path to put on the outside is not fixed. Based on what I found when
actually testing the code, it probably wouldn't be worth the effort.
--
Andrew (irc:RhodiumToad)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@tao11.riddles.org.uk, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, kes-kes@yandex.ru
Subject: Re: mark/restore failures on unsorted merge joins
In-Reply-To: <87blfm4hdv.fsf@news-spur.riddles.org.uk>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox