pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: WIP: Covering + unique indexes.
Date: Sat, 07 Apr 2018 21:52:38 +0100
Message-ID: <87in92ix46.fsf@news-spur.riddles.org.uk> (raw)
In-Reply-To: <73780c3f-0fd6-bfb1-a56c-6aa83a3f7377@sigaev.ru>
References: <56168952.4010101@postgrespro.ru>
	<CAH2-Wznq7whVwQ=xU1eejvuxkY-Gb18pjy40kmPdkaAba1qfMA@mail.gmail.com>
	<CAPpHfdt5oj0+h7GaNJtRf+kePN5V9uRr0fhFnOgghYQqrxMHfg@mail.gmail.com>
	<CAH2-Wzmjb8RU9v5cjw0MKTXMbKoJFDBRkt6WR5MsZj4Mf6kTkw@mail.gmail.com>
	<CAPpHfdvUG9qCrhbEG5MeWHA7Dg+9KaRcoJZEraXe2w2XYvDBug@mail.gmail.com>
	<dd1d58e1-d323-3f29-1604-b3fbf00dee0d@sigaev.ru>
	<CAH2-WzkcMOESrqcatEOFAEqGH7e8cpaB1gp3H7rkKTx3Qt6VyA@mail.gmail.com>
	<CAPpHfdv4=byzf+rH5DvzAS3odmej36KZFcvZ_f+1yc4KctBoMQ@mail.gmail.com>
	<CAH2-Wzn4N7HP4DS6Bzvd7hiozOseReu7mV1PftrUhANSCgUCRA@mail.gmail.com>
	<CAPpHfdsORjuUoEbAi-maApOXsyQNrfy9SyZuzDbOMic3uT-CcQ@mail.gmail.com>
	<CAH2-Wzk=xU1dDP7B_gq0S052OHeezEtibZ-BMF=YT-W1L+LWBw@mail.gmail.com>
	<95fb3cd8-648d-6362-302f-1b9bdc10e3e0@sigaev.ru>
	<CAH2-WzkGOA9j4wtteDrpXLTOZ13hFSSBf7YYUnqcSt8pv-E6HA@mail.gmail.com>
	<fc48f70f-6db6-4125-c8bd-d39d746ca58d@sigaev.ru>
	<CAH2-WznSBEGa7xiN80odXU9xOK37V_W6uz+kZTcr_vS3Z_--dA@mail.gmail.com>
	<73780c3f-0fd6-bfb1-a56c-6aa83a3f7377@sigaev.ru>

>>>>> "Teodor" == Teodor Sigaev <teodor@sigaev.ru> writes:

 >> I'll keep an eye on the buildfarm, since it's late in Russia.
 
 Teodor> Thank you very much! Now 23:10 MSK and I'll be able to follow
 Teodor> during approximately hour.

Support for testing amcaninclude via
pg_indexam_has_property(oid,'can_include') seems to be missing?

Also the return values of pg_index_column_has_property for included
columns seem a bit dubious... should probably be returning NULL for most
properties except 'returnable'.

I can look at fixing these for you if you like?

-- 
Andrew (irc:RhodiumToad)




view thread (217+ messages)  latest in thread

Message-ID: <87in92ix46.fsf@news-spur.riddles.org.uk>
Permalink:  ../87in92ix46.fsf@news-spur.riddles.org.uk/
Also on:    postgresql.org/message-id/87in92ix46.fsf@news-spur.riddles.org.uk

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andrew@tao11.riddles.org.uk, teodor@sigaev.ru, pg@bowt.ie, a.korotkov@postgrespro.ru, a.lubennikova@postgrespro.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: WIP: Covering + unique indexes.
  In-Reply-To: <87in92ix46.fsf@news-spur.riddles.org.uk>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox