pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andy Fan <zhihuifan1213@163.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Properly pathify the union planner
Date: Sun, 18 Feb 2024 17:07:50 +0800
Message-ID: <87jzn2gmwh.fsf@163.com> (raw)
In-Reply-To: <CAApHDvoXPZ0K2HPwumz2B-ptfsbdyTb1esF3OO6-_JuKYWziAw@mail.gmail.com>
References: <CAApHDvpb_63XQodmxKUF8vb9M7CxyUyT4sWvEgqeQU-GB7QFoQ@mail.gmail.com>
	<CAApHDvoV4QgNsXsegaCJQFHK4v8-gE7_DzXmSMgm_Hg+C+4oYg@mail.gmail.com>
	<CAMbWs49J2jv61DsQ_D=JgnuPMjbd1W3WoMw=-DB=zRpGYRh+yA@mail.gmail.com>
	<87o7cti48f.fsf@163.com>
	<CAApHDvoXPZ0K2HPwumz2B-ptfsbdyTb1esF3OO6-_JuKYWziAw@mail.gmail.com>


David Rowley <dgrowleyml@gmail.com> writes:

>>
>> The two if-clauses looks unnecessary, it should be handled by
>> pathkeys_count_contained_in already. The same issue exists in
>> pathkeys_useful_for_ordering as well. Attached patch fix it in master.
>
> I agree.  I'd rather not have those redundant checks in
> pathkeys_useful_for_setop(), and I do want those functions to be as
> similar as possible.  So I think adjusting it in master is a good
> idea.
>
> I've pushed your patch.
>
Thanks for the pushing!


-- 
Best Regards
Andy Fan






view thread (27+ messages)  latest in thread

Message-ID: <87jzn2gmwh.fsf@163.com>
Permalink:  ../87jzn2gmwh.fsf@163.com/
Also on:    postgresql.org/message-id/87jzn2gmwh.fsf@163.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: zhihuifan1213@163.com, dgrowleyml@gmail.com, guofenglinux@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Properly pathify the union planner
  In-Reply-To: <87jzn2gmwh.fsf@163.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox