From: ilmari@ilmari.org
To: pgsql-hackers@lists.postgresql.org
Subject: Re: perlcritic: prohibit map and grep in void conext
Date: Sun, 08 Aug 2021 00:15:47 +0100
Message-ID: <87o8a8g82k.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <87fsvzhhc4.fsf@wibble.ilmari.org>
References: <87fsvzhhc4.fsf@wibble.ilmari.org>
ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
> Hi hackers,
>
> In the patches for improving the MSVC build process, I noticed a use of
> `map` in void context. This is considered bad form, and has a
> perlcritic policy forbidding it:
> https://metacpan.org/pod/Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidMap.
>
> Attached is a patch that increases severity of that and the
> corresponding `grep` policy to 5 to enable it in our perlcritic policy,
> and fixes the one use that had already snuck in.
Added to the 2021-09 commitfest: https://commitfest.postgresql.org/34/3278/
- ilmari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, pgsql-hackers@lists.postgresql.org
Subject: Re: perlcritic: prohibit map and grep in void conext
In-Reply-To: <87o8a8g82k.fsf@wibble.ilmari.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox