From: ilmari@ilmari.org
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] pg_upgrade: report the reason for failing to open the cluster version file
Date: Thu, 19 Mar 2020 19:40:35 +0000
Message-ID: <87o8ssuo98.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <20200319192304.GA28431@momjian.us>
References: <87pne2w98h.fsf@wibble.ilmari.org>
<44115C15-EE49-4BDE-A976-2901384B5E60@yesql.se>
<87mu96w7c5.fsf@wibble.ilmari.org>
<20200226014844.GF17153@paquier.xyz>
<2760811A-9AF4-4725-8A8A-061940CCF962@yesql.se>
<CABUevEygyP_o9LmEWbSGzP3Wu-sstGSrQE9kq_WpuOEy1FOm5g@mail.gmail.com>
<20200226093551.GA106669@paquier.xyz>
<9878.1582732525@sss.pgh.pa.us>
<87k149w673.fsf@wibble.ilmari.org>
<20200319192304.GA28431@momjian.us>
Bruce Momjian <bruce@momjian.us> writes:
> On Wed, Feb 26, 2020 at 06:32:00PM +0000, Dagfinn Ilmari Mannsåker wrote:
>> Tom Lane <tgl@sss.pgh.pa.us> writes:
>>
>> > Michael Paquier <michael@paquier.xyz> writes:
>> >> On Wed, Feb 26, 2020 at 10:06:38AM +0100, Magnus Hagander wrote:
>> >>> +1, seems like that would be a regression in value.
>> >
>> >> Having more generic messages is less work for translators, we have
>> >> PG_VERSION in the file name, and that's more complicated to translate
>> >> in both French and Japanese. No idea about other languages.
>> >
>> > Just looking at the committed diff, it seems painfully obvious that these
>> > two messages were written by different people who weren't talking to each
>> > other. Why aren't they more alike? Given
>> >
>> > pg_fatal("could not open version file \"%s\": %m\n", ver_filename);
>> >
>> > (which seems fine to me), I think the second ought to be
>> >
>> > pg_fatal("could not parse version file \"%s\"\n", ver_filename);
>>
>> Good point. Patch attached.
>
> Patch applied, and other adjustments:
Thanks!
- ilmari
--
- Twitter seems more influential [than blogs] in the 'gets reported in
the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
to a mainstream media article. - Calle Dybedahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, bruce@momjian.us, tgl@sss.pgh.pa.us, michael@paquier.xyz, magnus@hagander.net, daniel@yesql.se, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] pg_upgrade: report the reason for failing to open the cluster version file
In-Reply-To: <87o8ssuo98.fsf@wibble.ilmari.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox